-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] 모달 띄우는 로직, 데이터 상태 로직 리팩토링.. #197
Merged
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
23e3d6d
#187 feat: 모달 상태 store
cindy-chaewon 2f33596
#187 fix: 모달 상태 store toggle 추가
cindy-chaewon 1034e74
#187 feat: 모달 zustand로 띄우기
cindy-chaewon f566a02
#187 fix: 모달 닫힐 때 workspace 클릭 상태 해제
cindy-chaewon 13021a7
#187 fix: 타임블록 생성도 적용 & 오류 해결
cindy-chaewon 52a7280
#187 fix: 사진 미리보기 안되던 오류 해결
cindy-chaewon 73ca6e8
#187 feat: delete 모달에도 적용
cindy-chaewon 77ee9fc
#187 refactor: 필요없는 코드 삭제
cindy-chaewon 5974228
#187 fix: 절대경로 수정
cindy-chaewon 50f68e9
#187 refactor: 워크스페이스, 블록생성
cindy-chaewon da808c4
#187 fix: 오류 해결
cindy-chaewon 2535167
#187 fix: 불필요한 코드 제거
cindy-chaewon 3a1feff
#187 refactor: 코드리뷰 반영
cindy-chaewon a741a89
#187 fix: 스토리북 코드 수정
cindy-chaewon 44f9b0c
#187 refactor: 코드리뷰 반영
cindy-chaewon 503f75f
#187 fix: 스토리북 모달 수정
cindy-chaewon bedbb83
#187 fix: useCallback 제거
cindy-chaewon f68a155
#187 refactor: 삭제 모달 zustand 로
cindy-chaewon f825ceb
#187 refactor: 리팩토링
cindy-chaewon 764eacc
#187 refactor: 코드리뷰 반영
cindy-chaewon 404f9a5
#187 fix: 스토리북 파일 에러 해결
cindy-chaewon aa418e7
#187 fix: svg 네이밍 정리
cindy-chaewon 6ae06bc
#187 fix: 오류 해결
cindy-chaewon 8b41e31
#187 fix : 머지 충돌 해결
cindy-chaewon fb23c44
#187 fix: 코드리뷰 반영
cindy-chaewon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 요 modal 컴포넌트가 굉장히 애매했는데 이제 없앨수 있군요!
그러면 지금
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞아요! 빈태그도 지워줬습니다!!