[Refactor] Refresh Token 쿠키 관리 로직 + teamId 저장 로직 리팩토링 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtttr1
approved these changes
Aug 4, 2024
| @@ -13,6 +13,8 @@ export const axiosInstance = axios.create({ | |||
|
|
|||
| export const axiosPublicInstance = axios.create({ | |||
| baseURL: `${import.meta.env.VITE_BASE_URL}/api/v1`, | |||
| withCredentials: true, | |||
There was a problem hiding this comment.
맞습니당 ! refreshToken을 넣은 쿠키를 주고받기 위해서는 credential 상태여야 하기 때문에 true로 설정했습니다.
Bowoon1216
approved these changes
Aug 4, 2024
|
|
||
| localStorage.setItem(ACCESS_TOKEN_KEY, data.data.accessToken); | ||
| originRequest.data.headers.Authorization = `Bearer ${data.data.accessToken}`; | ||
| localStorage.setItem(ACCESS_TOKEN_KEY, data.accessToken); |
There was a problem hiding this comment.
data 한번에 받아오는거 보기 좋네요 👍ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
#206
체크리스트