Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 임시 SNB 구현 #259

Merged
merged 5 commits into from
Oct 18, 2024
Merged

[Feat] 임시 SNB 구현 #259

merged 5 commits into from
Oct 18, 2024

Conversation

rtttr1
Copy link
Contributor

@rtttr1 rtttr1 commented Oct 18, 2024

해당 이슈 번호

closed #257

체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • ✅ 컨벤션을 지켰나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 💻 git rebase를 사용했나요?
  • 🙇‍♂️ 리뷰어를 지정했나요?
  • ✨ 저는 shared로 분리했어요.

📌 내가 알게 된 부분

💎 PR Point

📌스크린샷 (선택)

image

@rtttr1 rtttr1 self-assigned this Oct 18, 2024
@rtttr1 rtttr1 changed the title feat: 임시 SNB 구현 [Feat] 임시 SNB 구현 Oct 18, 2024
cindy-chaewon
cindy-chaewon approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@cindy-chaewon cindy-chaewon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wuzoo
wuzoo approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@wuzoo wuzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

임시 ! 고생하셨습니다 ~ 🚀

@github-actions GitHub Actions
Copy link

🚀 Storybook 확인하기 🚀

@github-actions GitHub Actions
Copy link

🚀 Storybook 확인하기 🚀

@github-actions GitHub Actions
Copy link

🚀 Storybook 확인하기 🚀

@rtttr1 rtttr1 merged commit 3962b60 into develop Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuzoo wuzoo wuzoo approved these changes

@cindy-chaewon cindy-chaewon cindy-chaewon approved these changes

@namdaeun namdaeun namdaeun approved these changes

@Bowoon1216 Bowoon1216 Awaiting requested review from Bowoon1216

Assignees

@rtttr1 rtttr1

Labels
✨Feature 🍭규홍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

임시 SNB
4 participants
@rtttr1 @namdaeun @cindy-chaewon @wuzoo