-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 버튼 컴포넌트 Size 수정 #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 ~ LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM입니당!! 짱짱~~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~ 덕분에 예쁜 버튼 Get! 😄
해당 이슈 번호
closed #272
체크리스트
💎 PR Point
피그마 -
Components
페이지의 버튼 스타일에 맞게padding
과font
지정해줬습니다.underline
variant의 경우 피그마 상에선 글자 크기에 맞게 버튼 영역이 설정되어 있어서 이걸 따로 size로 만들어야 하나 고민했는데, storybook에서 버튼 영역 잡아보니까 오히려 조금은 padding으로 버튼 영역을 설정해둔 게 더 자연스러운 것 같아서 따로 만들어주지 않았습니다 !📌스크린샷 (선택)
스토리북 확인해주셔요 ~