Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 버튼 컴포넌트 Size 수정 #274

Merged
merged 6 commits into from
Oct 20, 2024

Conversation

namdaeun
Copy link
Member

해당 이슈 번호

closed #272


체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [feat] PR을 등록한다.
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • ✅ 컨벤션을 지켰나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?
  • 💻 git rebase를 사용했나요?
  • 🙇‍♂️ 리뷰어를 지정했나요?

💎 PR Point

피그마 - Components 페이지의 버튼 스타일에 맞게 paddingfont 지정해줬습니다.

underline variant의 경우 피그마 상에선 글자 크기에 맞게 버튼 영역이 설정되어 있어서 이걸 따로 size로 만들어야 하나 고민했는데, storybook에서 버튼 영역 잡아보니까 오히려 조금은 padding으로 버튼 영역을 설정해둔 게 더 자연스러운 것 같아서 따로 만들어주지 않았습니다 !


📌스크린샷 (선택)

스토리북 확인해주셔요 ~

Copy link

🚀 Storybook 확인하기 🚀

Copy link

🚀 Storybook 확인하기 🚀

Copy link

🚀 Storybook 확인하기 🚀

Copy link

🚀 Storybook 확인하기 🚀

Copy link
Contributor

@wuzoo wuzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 ~ LGTM

Copy link
Contributor

@rtttr1 rtttr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cindy-chaewon cindy-chaewon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM입니당!! 짱짱~~!

Copy link
Contributor

@Bowoon1216 Bowoon1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 덕분에 예쁜 버튼 Get! 😄

@namdaeun namdaeun merged commit eae50f3 into develop Oct 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

버튼 size 수정
5 participants