[Feat] Login, Singup 페이지 GUI 반영 #317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namdaeun
reviewed
Nov 6, 2024
| <Flex styles={{ direction: 'column', width: '100%', gap: '1.6rem' }}> | ||
| <TermsAgreeButton isClicked={totalAgreeClicked} onClick={handleAllTermsAgree} /> | ||
|
|
||
| <TermItem |
There was a problem hiding this comment.
map을 사용해서 TermItem 컴포넌트를 리턴하면 코드의 중복을 줄일 수 있을 것 같습니다
| }; | ||
|
|
||
| export const useTermForm = () => { | ||
| const [totalAgreeClicked, setTotalAgreeClicked] = useState(false); |
There was a problem hiding this comment.
불리언 값의 상태이니 be동사를 앞에 붙이는 게 좋을 것 같습니다
Comment on lines
+26
to
+32
| <Input | ||
| name="birth" | ||
| value={info.birth} | ||
| onChange={handleBirthChange} | ||
| label="생년월일" | ||
| placeholder={PLACEHOLDER.BIRTHDAY} | ||
| /> |
There was a problem hiding this comment.
생년월일 DatePicker로 지정하는 거 아니었나용 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 이슈 번호
closed #
체크리스트
💎 PR Point
로그인 페이지와 회원가입 페이지에서 바뀐 GUI를 반영하였습니다 ! 퍼블리싱이여서 딱히 포인트는 없습니다
불필요한 훅이나 파일들을 삭제하였고, 그리고 필요하다 싶은 커스텀 훅 정도만 만들어두었습니다. 인풋의 유효성 검사나 폼 제출 로직은 아직 제대로 구현하지 않은 상태여서 페이지 컴포넌트들, 스타일 정도만 확인해주시면 감사하겠슴니당 ~
그리고 추후에
funnel구조를 붙힐 예정인데요 ! 생각해보았을 때 각 회원가입에 대한 단계는url로 접근할 수 없어야 하고이용약관->univ 폼->info 폼순서대로 유저에게 보여주어야 하기 때문에 퍼널 구조를 구현할 생각입니다.📌스크린샷 (선택)
2024-11-06.3.32.50.mov