[Refactor/#109] Home view 코드 간결화

Team-Umbba · Aug 28, 2023 · 1c1c300 · 1c1c300
1 parent 04dee80
commit 1c1c300
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/src/main/java/com/sopt/umbba_android/presentation/home/HomeFragment.kt b/app/src/main/java/com/sopt/umbba_android/presentation/home/HomeFragment.kt
@@ -56,7 +56,7 @@ class HomeFragment : BindingFragment<FragmentHomeBinding>(R.layout.fragment_home
     private fun observeData() {
         viewModel.homeData.observe(viewLifecycleOwner) {
             setBackground(it.section)
-            if (it.index == 8 && viewModel.isCloseEnding.value == false && viewModel.isObserveIndex.value == false) {
+            if (it.index == 8 && viewModel.isShowedEndingPage()) {
                 viewModel.setStateObserveIndex()
                 startForResult.launch(Intent(requireActivity(), EndingActivity::class.java))
             }
@@ -99,7 +99,7 @@ class HomeFragment : BindingFragment<FragmentHomeBinding>(R.layout.fragment_home
 
     override fun onResume() {
         super.onResume()
-        if (viewModel.isObserveIndex.value != true) {
+        if (viewModel.isObserveIndex.value == false) {
             viewModel.getHomeData()
         }
         viewModel.getResponseCase()

diff --git a/app/src/main/java/com/sopt/umbba_android/presentation/home/viewmodel/HomeViewModel.kt b/app/src/main/java/com/sopt/umbba_android/presentation/home/viewmodel/HomeViewModel.kt
@@ -68,4 +68,8 @@ class HomeViewModel(private val homeRepositoryImpl: HomeRepositoryImpl) : ViewMo
     fun setStateObserveIndex() {
         _isObserveIndex.value = true
     }
+
+    fun isShowedEndingPage(): Boolean {
+        return (_isCloseEnding.value == false && _isObserveIndex.value == false)
+    }
 }