Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design/#12] 답변 화면 UI 구현 #13

Merged
merged 11 commits into from
Jul 6, 2023
Merged

[Design/#12] 답변 화면 UI 구현 #13

merged 11 commits into from
Jul 6, 2023

Conversation

ss99x2002
Copy link
Member

🎀 Related Issues

close #12

🤔 What Did You Do

  • Answer Activity UI 구현
  • 문답부분 custom appbar 구현

📸 Screenshot

_2023_07_06_19_06_01_548.mp4

⁉️ etc

  • 문답 부분 custom appbar에서 답변 부분에만 있는 체크 아이콘은 데이터바인딩으로 visible을 조정했습니다.

  • custom appbar의 타이틀은 서버에서 받아오는 타이틀에 따라서 바뀔 것 같아서, titleText에 넣을 title이라는 변수를 하나 더 추가했습니다. 현재는 예시로 '나의 어린시절'이 들어가 있지만 추후 @{title} 로 바뀔것 같습니다.

  • 폰트 시스템에서 body 16sp가 body1_1, body1_2로 나눠져있어 수정했습니다.

  • 색상과 counter 제한 길이는 임의로 해두었습니다. 디자인 색 나오는대로 수정 예정입니다.

@ss99x2002 ss99x2002 added design UI 추가 및 수정 서현 labels Jul 6, 2023
@ss99x2002 ss99x2002 requested a review from yeoncheong July 6, 2023 10:26
@ss99x2002 ss99x2002 self-assigned this Jul 6, 2023
Copy link
Contributor

@yeoncheong yeoncheong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 데이터바인딩을 잘 활용하네요!!
중간중간 ctrl+alt+l도 한번씩 눌러주세요~


<!-- answer activity-->
<string name="answer_edittext_hint">답변을 입력해주세요.</string>
<string name="answer_title">가장 오랜된 기억</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오탈자 있어요!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하핫 수정할게요

@ss99x2002 ss99x2002 merged commit 9909230 into develop Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design UI 추가 및 수정 서현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] 답변 화면 UI 구현
2 participants