Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/#59] 푸시 알림 권한 허용 #62

Merged
merged 7 commits into from
Jul 15, 2023
Merged

[Feat/#59] 푸시 알림 권한 허용 #62

merged 7 commits into from
Jul 15, 2023

Conversation

yeoncheong
Copy link
Contributor

🎀 Related Issues

close #59

🤔 What Did You Do

  • 알림 설정 시 푸시 알림 권한 띄우기
  • 알림 거부 시 설정화면으로 연결 또는 토스트 메세지 띄우기
  • 초대 하는측/받는측 로직 연결

⁉️ etc

@yeoncheong yeoncheong added feature 기능 개발 연진 labels Jul 14, 2023
@yeoncheong yeoncheong requested a review from ss99x2002 July 14, 2023 20:57
@yeoncheong yeoncheong self-assigned this Jul 14, 2023
@yeoncheong yeoncheong requested review from ddongseop and 0lynny July 14, 2023 20:59
Copy link
Member

@ddongseop ddongseop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 코드를 보고 시력이 1.0 증가했습니다... 정말 아름다운 코드네요

Copy link
Member

@0lynny 0lynny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 다 완벽한데 구멍 하나가 있네요. 황홀 ....


class InviteCodeActivity :
BindingActivity<ActivityInviteCodeBinding>(R.layout.activity_invite_code),
View.OnClickListener {

private val viewModel by viewModels<InviteCodeViewModel>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ViewModel .. MVVM 저도 알려주세요!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 통신할 때 viweModel Factory로 바꾸면 됩니다


companion object {
const val INVITE_CODE_PATTERN = "^[A-Z]{4}-[a-zA-Z0-9]{6}$"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어어라!! 어디서 많이 본 코드가!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조건처리.. 굿

Copy link
Member

@ss99x2002 ss99x2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 수고하셨습니당


class InviteCodeActivity :
BindingActivity<ActivityInviteCodeBinding>(R.layout.activity_invite_code),
View.OnClickListener {

private val viewModel by viewModels<InviteCodeViewModel>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 통신할 때 viweModel Factory로 바꾸면 됩니다


companion object {
const val INVITE_CODE_PATTERN = "^[A-Z]{4}-[a-zA-Z0-9]{6}$"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조건처리.. 굿

} else if (shouldShowRequestPermissionRationale(Manifest.permission.POST_NOTIFICATIONS)) {
// 왜 알림을 허용해야 하는지에 대한 설명 + 권한 거절 시 권한 설정 화면으로 이동
Snackbar.make(binding.root, "알림 권한을 설정하면 답변 작성 요청 알림을 받아볼 수 있습니다.", Snackbar.LENGTH_SHORT).show()
val intent = Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS).setData(Uri.parse("package:"+ this.packageName))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

왕 권한처리 이렇게 하는거군요 배워갑니다

@yeoncheong yeoncheong merged commit 361c4eb into develop Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 기능 개발 연진
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 푸시 알림 권한 허용
4 participants