[Feat/#61] 홈화면 API 연결, 배경 적용 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeoncheong
approved these changes
Jul 15, 2023
Comment on lines
+42
to
47
| @SuppressLint("StringFormatMatches") | ||
| private fun setData(data: HomeResponseDto.HomeData) { | ||
| with(binding) { | ||
| ivBackground.load("https://i.ibb.co/sRV9Vr4/iv-maru.jpg") | ||
| tvTitle.text = getString(R.string.main_topic, data.index, data.topic) | ||
| } | ||
| } |
There was a problem hiding this comment.
이 부분이 배경 위에있는 #1 나의 어린시절을 작성하는 부분이에요! 근데 "#$data.index ... " 이런식으로 텍스트 대응하니까 ide에서 getString 방식을 추천해줘서 바꿨더니 들어갔어요
| interface HomeService { | ||
| @Headers("Content-Type: application/json") |
There was a problem hiding this comment.
사실 이것도 한번 확인해봐야겠어요 테스트 가능한대로 해보고 바로 지우던가 하겠습니다
Comment on lines
+18
to
+28
| fun getHomeData() { | ||
| viewModelScope.launch { | ||
| homeRepositoryImpl.getHomeData() | ||
| .onSuccess { response -> | ||
| Log.e("hyeon", "getHomeData 성공") | ||
| _homeData.value = response.data | ||
| }.onFailure { error -> | ||
| Log.e("hyeon", "getHomeData 실패 " + error.message) | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎀 Related Issues
close #61
🤔 What Did You Do
이미지 비율은 디자이너님 측에 말해서 사이즈 조정할 예정입니다.
지금 토큰이 유효하지않아서 스크린샷을 못찍어요호
근데 data get을 fragment 생명주기 중 언제 해야하는지.. 의문이 생깁니다.
현재 작성한 코드로 하니까 view가 생성되고 1초정도 이전 화면이 보이고 get 한 데이터들로 설정 되는거같아요. 이 부분 피드백 부탁드립니다 !!!