[Feat/#63] 메인-문답-답변 API 연결 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeoncheong
approved these changes
Jul 17, 2023
Comment on lines
+17
to
+26
| @SerialName("response_case") | ||
| val responseCase: Int, | ||
| @SerialName("invite_code") | ||
| val inviteCode: String?, | ||
| @SerialName("invite_username") | ||
| val inviteUserName: String?, | ||
| @SerialName("install_url") | ||
| val installUrl: String?, | ||
| @SerialName("relative_user_active") | ||
| val relativeUserActive: Boolean? |
There was a problem hiding this comment.
언더바 뺀거 아주 좋습니다. 명세서가 있다고 완전히 똑같이 네이밍하지 않아도 되기 때문이죠!!
저희는 변수명에 언더바를 넣지 않기 때문에 너무 잘 하셨습니다 👍
| @@ -70,7 +70,7 @@ | |||
| app:chipMinHeight="26dp" | |||
| app:textEndPadding="12dp" | |||
| app:textStartPadding="12dp" | |||
| tools:text="# 타임머신" /> | |||
| android:text="# 어린 시절" /> | |||
Comment on lines
+57
to
+61
| val clipboard: ClipboardManager = | ||
| requireActivity().getSystemService(CLIPBOARD_SERVICE) as ClipboardManager | ||
| val clip = ClipData.newPlainText("label", binding.tvInviteCode.text) | ||
| clipboard.setPrimaryClip(clip) | ||
| Toast.makeText(requireActivity(), "초대 코드가 복사되었습니다", Toast.LENGTH_SHORT).show() |
There was a problem hiding this comment.
클립보드 써본적이 없었는데 생각보다 간단하고 코드가 너무 깔끔하네요
저도 배워갑니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎀 Related Issues
close #63
🤔 What Did You Do
한 이슈에 우다다 했는데.. 계속 변동사항이 있고, 테스트가 필요한 부분이 있습니다.
리스트 api 연결 pr 올리기 위해서 지금 올립니다! 테스트 후 수정 필요한 부분들은 새로 이슈파서 작성하도록 하겠습니다.