[Feat/#82] 초대하는 측 / 초대받는 측 분기처리 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss99x2002
approved these changes
Jul 19, 2023
|
|
||
| @Parcelize | ||
| data class User( | ||
| var isReceiver: Boolean, |
There was a problem hiding this comment.
isReceiver도 User에 넣으셨군여 저는 개인적으로 나중에는 안쓰긴해도 넣는게 더 낫다고 생각했어서 좋은거같습니다.
There was a problem hiding this comment.
온보딩에서 수집되는 모든 정보가 딱 온보딩 과정에서만 사용하기 때문에 isReceiver도 같이 관리하기로 했습니다!!
| val userData = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { | ||
| intent.getParcelableExtra("userData", User::class.java) | ||
| } else { | ||
| intent.getParcelableExtra<User>("userData") |
There was a problem hiding this comment.
저도 이제 이렇게 할게요 진짜로 ㄷㅐ박... 새로운 사실 알게됨
putExtra("section")은 이제 그만 ~>
There was a problem hiding this comment.
굿굿
데이터 클래스를 한번에 묶어서 보낼 수 있어서 좋더라고요
근데 getParcelableExtra가 지금 deprecated 되어서 버전 따라 보내줘야하더라고요
이것만 신경쓰면 완전 편합니다!!!
Comment on lines
101
to
111
| user.name = binding.etName.text.toString() | ||
| user.gender = | ||
| if (binding.chip1.isChecked) { | ||
| binding.chip1.text.toString() | ||
| } else if (binding.chip2.isChecked){ | ||
| binding.chip2.text.toString() | ||
| } else { | ||
| null | ||
| } | ||
| user.bornYear = binding.etYear.text.toString().toInt() | ||
| } |
There was a problem hiding this comment.
제가 with(binding)을 자주 써서 그런가
binding 이 중복되면 with(binding) 해주고시퍼요 haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎀 Related Issues
close #82
🤔 What Did You Do