pythonSubmit.py does not treat fully-qualified grid filenames and fully-qualified logfile-definitions filenames correctly #600
Assignees
Labels
bug
Something isn't working
severity_minor
This bug is not very severe
urgency_low
This issue is not urgent
Comments
jeffriley
added
bug
jeffriley
added a commit
to jeffriley/COMPAS-1
that referenced
this issue
Jul 28, 2021
- Added code to copy any grid file and/or logfile-definitions file specified to output container. - Copying a large grid file could take time, and take up much space, so added new program option '--store-input-files' which is TRUE by default. If FALSE, neither the grid file (if specified) nor the logfile-definitions file (if specified) will be copied to the output container (if TRUE, both will be copied (if specified)). - Fixed issue TeamCOMPAS#600: changed pythonSubmit.py to treat fully-qualified grid filenames and fully-qualified logfile-definitions filenames correctly (i.e. don't add CWD if the filename is already fully-qualified). - Fixed issue TeamCOMPAS#601: changed pythonSubmit.py to put all boolean parameters on the commandline, with True or False value.
This was referenced Jul 28, 2021
|
Fixed in PR #602 v02.21.00 After this change, any grid file or logfile-definitions file that is specified as a fully-qualified filename (i.e. the string given as the value of the 'grid' variable or 'logfile_definitions' variable in pythonSubmit.py includes both a path and a base filename) will be passed as given to the commandline - no path will be added by pythonSubmit.py (either CWD or compas_input_path_override). The assumption is that if the user specifies a path then that's the path that should be used. |
reinhold-willcox
pushed a commit
that referenced
this issue
Aug 2, 2021
…fect repairs (#603) * Enhancement and Defect Repairs: - Added code to copy any grid file and/or logfile-definitions file specified to output container. - Copying a large grid file could take time, and take up much space, so added new program option '--store-input-files' which is TRUE by default. If FALSE, neither the grid file (if specified) nor the logfile-definitions file (if specified) will be copied to the output container (if TRUE, both will be copied (if specified)). - Fixed issue #600: changed pythonSubmit.py to treat fully-qualified grid filenames and fully-qualified logfile-definitions filenames correctly (i.e. don't add CWD if the filename is already fully-qualified). - Fixed issue #601: changed pythonSubmit.py to put all boolean parameters on the commandline, with True or False value. * Update Log.h Removed extraneous include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
pythonSubmit.py does not treat fully-qualified grid filenames and fully-qualified logfile-definitions filenames correctly - it adds CWD even though the filename is already fully-qualified.
Label the issue
urgency_low- This issue is not urgentseverity_minor- This is a minor bug with minimal impactTo Reproduce
Specify 'grid = /dirname/gridfilename.txt' in pythonSubmit.py
pythonSubmit.py will prepend the grid filename with the CWD, which then causes COMPAS to fail (file not found)
Expected behavior
Don't add CWD to grid filename or logfile-definitions file if already fully-qualified
Screenshots
If applicable, add screenshots to help explain your problem.
Versioning (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: