Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-ZAMS Initialization #1156

Open
wants to merge 52 commits into
base: dev_frozen_for_comparison_with_genzams_changes
Choose a base branch
from
Open

Non-ZAMS Initialization #1156

wants to merge 52 commits into from

Commits on Dec 17, 2021

  1. added options for initial stellar type, still need to add sanity check

    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    4eb2e6b View commit details
    Browse the repository at this point in the history

  2. added parameters to handle p_InitialStellarType as input to a star

    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    738c6cc View commit details
    Browse the repository at this point in the history

  3. added stellar type into assignment for single stars

    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    971298a View commit details
    Browse the repository at this point in the history

  4. added stellar type assignment for binary star components

    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    41bfece View commit details
    Browse the repository at this point in the history

  5. Cleaned up initial stellar type call, to take integer input but conve… 

    …rt it to stellar type for getters
    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    9186d0f View commit details
    Browse the repository at this point in the history

  6. Cleaned up function calls and PROGRAM_OPTIONS settings for custom ini… 

    …tial stellar type
    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    f5b4e3a View commit details
    Browse the repository at this point in the history

  7. code now compiles, and the stars get set correctly (according to stdo… 

    …ut), but they are not internally set correctly - the timestep calculations do not use the stellar types, they use the default (min) in BaseStar
    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    cc4d0aa View commit details
    Browse the repository at this point in the history

  8. added check in Star::SwitchTo to switch also if setting the initial S… 

    …tellarType, now the code seems to run properly
    @reinhold-willcox
    reinhold-willcox committed Dec 17, 2021
    Configuration menu
    Copy the full SHA
    411abda View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. temp work

    @reinhold-willcox
    reinhold-willcox committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    a5f1efc View commit details
    Browse the repository at this point in the history

  2. fixed references to hurley stellar type numbers in initial stellar ty… 

    …pe option. Now users submit a string referring to the stellar type
    @reinhold-willcox
    reinhold-willcox committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    d9bfb70 View commit details
    Browse the repository at this point in the history

  3. changelog

    @reinhold-willcox
    reinhold-willcox committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    cb2ca24 View commit details
    Browse the repository at this point in the history

  4. cleaned up call for initial stellar type in main.cpp (it was still us… 

    …ing previous stellar type num functionality)
    @reinhold-willcox
    reinhold-willcox committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    0fcb204 View commit details
    Browse the repository at this point in the history

  5. cleaned up temporary comments and string list of available stellar types

    @reinhold-willcox
    reinhold-willcox committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    8a15926 View commit details
    Browse the repository at this point in the history

  6. added initial stellar types to program options documentation

    @reinhold-willcox
    reinhold-willcox committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    5a341ed View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    cbd0110 View commit details
    Browse the repository at this point in the history

  2. fixed bitwise operators to booleans

    @reinhold-willcox
    reinhold-willcox committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    6cb9e13 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    eefb7dd View commit details
    Browse the repository at this point in the history

  2. updated pythonSubmitDemo to use OPTIMISTIC CE assumption, and common_… 

    …envelope_allow_radiative_envelope_survive to True to reproduce the methods paper figure
    @reinhold-willcox
    reinhold-willcox committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    2cd2595 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    e44cf6e View commit details
    Browse the repository at this point in the history

  2. fixed immediate RLOF setting in pythonSubmitDemo.py

    @reinhold-willcox
    reinhold-willcox committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    7e26ee0 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. added fastforwarding function to correctly assign stellar attributes … 

    …to non-MS stars
    @reinhold-willcox
    reinhold-willcox committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    8030306 View commit details
    Browse the repository at this point in the history

  2. added initial radius and initial luminosity parameters to track those… 

    … values even when the initial stellar type changes (so ZAMS values always correspond to H ZAMS).
    @reinhold-willcox
    reinhold-willcox committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    e3afcbb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    8530d4e View commit details
    Browse the repository at this point in the history

  4. added initial L and R to STAR_PROPS

    @reinhold-willcox
    reinhold-willcox committed Jan 19, 2022
    Configuration menu
    Copy the full SHA
    09f42c2 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. removed commented line

    @reinhold-willcox
    reinhold-willcox committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    a351b68 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    3328b01 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    e687a47 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    e28e271 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. fixes for jeff's requested changes

    @reinhold-willcox
    reinhold-willcox committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    8d56f07 View commit details
    Browse the repository at this point in the history

  2. added initial temperature param

    @reinhold-willcox
    reinhold-willcox committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    1f84af6 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    c41fb42 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7a7f7cd View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. changes

    @reinhold-willcox
    reinhold-willcox committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    e7c625b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d6cc65b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4c4b463 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    aa6d7e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. readded missing stellar properties

    @reinhold-willcox
    reinhold-willcox committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    9b7d172 View commit details
    Browse the repository at this point in the history

  2. removed anomalous m_MomentOfIntertia and m_AngluarMomentum in NS.h, t… 

    …hese are superceded by the same parameters with the suffix _CGS
    @reinhold-willcox
    reinhold-willcox committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ee607bc View commit details
    Browse the repository at this point in the history

  3. fixed ordering of comments in changelog

    @reinhold-willcox
    reinhold-willcox committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    5072f02 View commit details
    Browse the repository at this point in the history

  4. returned BINARY_PROPERTY::UNBOUND to its former position after BINARY… 

    …_PROPERTY::TIME in the BSE_DETAILED_OUTPUT_REC output
    @reinhold-willcox
    reinhold-willcox committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    87094e1 View commit details
    Browse the repository at this point in the history

  5. added new options to the end of program options list defaults

    @reinhold-willcox
    reinhold-willcox committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3b545c3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    01a8376 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8d547bf View commit details
    Browse the repository at this point in the history

  2. changelog

    @reinhold-willcox
    reinhold-willcox committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1b01133 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    4bc8dba View commit details
    Browse the repository at this point in the history

  2. removed double ZSOL_ASPLUND def

    @reinhold-willcox
    reinhold-willcox committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    7f7ec74 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Merge branch 'dev' into generalized_zams_stellar_type

    @reinhold-willcox
    reinhold-willcox committed May 15, 2024
    Configuration menu
    Copy the full SHA
    0c8a0ec View commit details
    Browse the repository at this point in the history

  2. documentation

    @reinhold-willcox
    reinhold-willcox committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a37185e View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. first step in converting 'ZAMS' values to 'Initial' values. This is m… 

    …ostly just a regex search/replace, so it is likely broken, but it at least compiles
    @reinhold-willcox
    reinhold-willcox committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3386652 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. cleaning up separate definitions, incl. in constants.h, of InitialMas… 

    …s vs MZAMS (and similar for the other initial atts)
    @reinhold-willcox
    reinhold-willcox committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d49b05b View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. very many, mostly cosmetic, changes, to ensure correct declaration of… 

    … variables related to initial mass, radius, temperature and luminosity (including STAR_PROPERTIES and related functions), as distinct from the ZAMS variables, so that both can be used depending on the context
    @reinhold-willcox
    reinhold-willcox committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    954d551 View commit details
    Browse the repository at this point in the history

  2. Cleaned up FastForward, so it only shows up in HeMS and Remnants, and… 

    … sets ZAMS values to -1 (for debugging purposes)
    @reinhold-willcox
    reinhold-willcox committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    83fdd49 View commit details
    Browse the repository at this point in the history