[FEAT] 커뮤니티 게시글 전체조회 API #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yubinquitous
commented
Mar 25, 2024
HYOSITIVE
approved these changes
Mar 26, 2024
Co-authored-by: Chae Jeong Ah <jokj624@gmail.com>
Co-authored-by: Chae Jeong Ah <jokj624@gmail.com>
Co-authored-by: Chae Jeong Ah <jokj624@gmail.com>
|
@yubinquitous |
@jokj624 요거 반영해서 신고하기 API 제작하겠습니다! 감사합니다~! |
yubinquitous
commented
Apr 1, 2024
| SELECT cp.id, u.nickname, cp.title, cp.body, cp.content_url, cp.content_title, cp.content_description, cp.thumbnail_url, cp.created_at | ||
| FROM community_post cp | ||
| JOIN "user" u ON cp.user_id = u.id | ||
| LEFT JOIN community_post_report_user cpru ON cp.id = cpru.community_post_id AND cpru.report_user_id = $1 |
There was a problem hiding this comment.
찾아보니 LEFT JOIN을 사용하는 것이 가장 일반적인 방법이라고 합니다!
다른 방법으로는 EXCEPT, NOT EXISTS, NOT IN 등이 있습니다.
LEFT JOIN의 성능이 안 좋으면 나중에 이런 방법들과 비교해서 개선해보려는데 어떠세요?-? @jokj624 @HYOSITIVE
There was a problem hiding this comment.
LEFT JOIN 후 NULL 조건으로 필터링하는 로직 확인했습니다! 성능 상 큰 문제는 없을 것 같아요. 당장은 신고된 글 자체 개수가 많지 않으니...!
| const getCommunityPostsCount = async (client, userId) => { | ||
| const { rows } = await client.query( | ||
| ` | ||
| SELECT COUNT(*)::int |
There was a problem hiding this comment.
전체 커뮤니티 게시글 수를 조회하는 쿼리문도 LEFT JOIN을 사용해 신고글을 필터링했습니다!
yubinquitous
commented
Apr 1, 2024
HYOSITIVE
reviewed
Apr 9, 2024
| @@ -85,6 +85,7 @@ router.get( | |||
| router.get( | |||
| '/posts', | |||
| checkUser, | |||
| [...communityValidator.getCommunityPostsValidator, validate], | |||
|
@yubinquitous 2차 리뷰 완료했습니다! 정아 어프룹 후에 머지 부탁드려요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용