Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] PATCH /category/:categoryId 카테고리 수정 api 구현 #51

Merged
merged 7 commits into from
Jan 14, 2022
Merged

[FEAT] PATCH /category/:categoryId 카테고리 수정 api 구현 #51

merged 7 commits into from
Jan 14, 2022

Conversation

jokj624
Copy link
Member

@jokj624 jokj624 commented Jan 14, 2022

  • 카테고리 수정 api 구현
  • now() 로 삽입 시 utc 시간으로 들어가서 dayjs로 asia/seoul 시간으로 넣었음 -> 릴리즈 때 고민해야함

@jokj624 jokj624 added 🚀 enhancement New feature or request priority 2️⃣ labels Jan 14, 2022
@jokj624 jokj624 self-assigned this Jan 14, 2022
HYOSITIVE
HYOSITIVE reviewed Jan 14, 2022
View reviewed changes
functions/db/category.js Outdated
const updateCategory = async (client, categoryId, title, imageId) => {
const nowTime = dayjs().tz("Asia/Seoul").format();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nowTime보다는 currentTime이 문법에 맞는 표현이에효!

functions/db/category.js Outdated
AND is_deleted = FALSE
`,
[categoryId],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탭 지워주시면 좋을거같아용

functions/db/category.js Outdated
RETURNING *
`,
[data.title, data.imageId, categoryId, nowTime],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

탭 지워주세용

@HYOSITIVE HYOSITIVE merged commit 042ed4e into develop Jan 14, 2022
@jokj624 jokj624 mentioned this pull request Jan 14, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYOSITIVE HYOSITIVE HYOSITIVE left review comments

Assignees

@jokj624 jokj624

Labels
🚀 enhancement New feature or request priority 2️⃣
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jokj624 @HYOSITIVE