Fix title of the subject when sharing an URL

TeamNewPipe · Jun 11, 2021 · 2fb8636 · 2fb8636
1 parent c972940
commit 2fb8636
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/app/src/main/java/org/schabi/newpipe/RouterActivity.java b/app/src/main/java/org/schabi/newpipe/RouterActivity.java
@@ -234,7 +234,7 @@ private void showUnsupportedUrlDialog(final String url) {
                 .setPositiveButton(R.string.open_in_browser,
                         (dialog, which) -> ShareUtils.openUrlInBrowser(this, url))
                 .setNegativeButton(R.string.share,
-                        (dialog, which) -> ShareUtils.shareText(this, "", url)) // no subject
+                        (dialog, which) -> ShareUtils.shareText(this, "", url, false)) //no subject
                 .setNeutralButton(R.string.cancel, null)
                 .setOnDismissListener(dialog -> finish())
                 .show();

diff --git a/app/src/main/java/org/schabi/newpipe/util/ShareUtils.java b/app/src/main/java/org/schabi/newpipe/util/ShareUtils.java
@@ -213,13 +213,21 @@ private static String getDefaultAppPackageName(final Context context, final Inte
      * @param url     the url to share
      */
     public static void shareText(final Context context, final String subject, final String url) {
+        shareText(context, subject, url, true);
+    }
+
+
+    public static void shareText(final Context context,
+                                 final String subject,
+                                 final String url,
+                                 final boolean showPreviewText) {
         final Intent shareIntent = new Intent(Intent.ACTION_SEND);
         shareIntent.setType("text/plain");
-        if (!subject.isEmpty()) {
+        if (!subject.isEmpty() && showPreviewText) {
             shareIntent.putExtra(Intent.EXTRA_SUBJECT, subject);
+            shareIntent.putExtra(Intent.EXTRA_TITLE, subject);
         }
         shareIntent.putExtra(Intent.EXTRA_TEXT, url);
-        shareIntent.putExtra(Intent.EXTRA_TITLE, context.getString(R.string.share_dialog_title));
 
         openAppChooser(context, shareIntent, false);
     }