Adress requested changes and remove an unused return value in NewPipe…

…TextViewHelper
TeamNewPipe · Oct 2, 2021 · 5eee81d · 5eee81d
1 parent f38cf53
commit 5eee81d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 12 deletions.
diff --git a/app/src/main/java/org/schabi/newpipe/util/NewPipeTextViewHelper.java b/app/src/main/java/org/schabi/newpipe/util/NewPipeTextViewHelper.java
@@ -29,11 +29,8 @@ private NewPipeTextViewHelper() {
      * @param textView the {@link TextView} on which sharing the selected text. It should be a
      *                 {@link NewPipeTextView} or a {@link NewPipeEditText} (even if
      *                 {@link TextView standard TextViews} are supported).
-     *
-     * @return true if no exceptions occurred when getting the selected text, sharing it and
-     * deselecting it, otherwise an exception
      */
-    public static boolean shareSelectedTextWithShareUtils(@NonNull final TextView textView) {
+    public static void shareSelectedTextWithShareUtils(@NonNull final TextView textView) {
         if (!(textView instanceof NewPipeEditText)) {
             final CharSequence textViewText;
             if (textView instanceof NewPipeTextView) {
@@ -59,8 +56,6 @@ public static boolean shareSelectedTextWithShareUtils(@NonNull final TextView te
             shareSelectedTextIfNotNullAndNotEmpty(textView, selectedText);
             Selection.setSelection(text, editText.getSelectionEnd());
         }
-
-        return true;
     }
 
     @Nullable

diff --git a/app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java b/app/src/main/java/org/schabi/newpipe/views/NewPipeEditText.java
@@ -7,10 +7,9 @@
 import androidx.annotation.Nullable;
 import androidx.appcompat.widget.AppCompatEditText;
 
+import org.schabi.newpipe.util.NewPipeTextViewHelper;
 import org.schabi.newpipe.util.external_communication.ShareUtils;
 
-import static org.schabi.newpipe.util.NewPipeTextViewHelper.shareSelectedTextWithShareUtils;
-
 /**
  * An {@link AppCompatEditText} which uses {@link ShareUtils#shareText(Context, String, String)}
  * when sharing selected text by using the {@code Share} command of the floating actions.
@@ -38,7 +37,8 @@ public NewPipeEditText(@NonNull final Context context,
     @Override
     public boolean onTextContextMenuItem(final int id) {
         if (id == android.R.id.shareText) {
-            return shareSelectedTextWithShareUtils(this);
+            NewPipeTextViewHelper.shareSelectedTextWithShareUtils(this);
+            return true;
         }
         return super.onTextContextMenuItem(id);
     }

diff --git a/app/src/main/java/org/schabi/newpipe/views/NewPipeTextView.java b/app/src/main/java/org/schabi/newpipe/views/NewPipeTextView.java
@@ -7,10 +7,9 @@
 import androidx.annotation.Nullable;
 import androidx.appcompat.widget.AppCompatTextView;
 
+import org.schabi.newpipe.util.NewPipeTextViewHelper;
 import org.schabi.newpipe.util.external_communication.ShareUtils;
 
-import static org.schabi.newpipe.util.NewPipeTextViewHelper.shareSelectedTextWithShareUtils;
-
 /**
  * An {@link AppCompatTextView} which uses {@link ShareUtils#shareText(Context, String, String)}
  * when sharing selected text by using the {@code Share} command of the floating actions.
@@ -38,7 +37,8 @@ public NewPipeTextView(@NonNull final Context context,
     @Override
     public boolean onTextContextMenuItem(final int id) {
         if (id == android.R.id.shareText) {
-            return shareSelectedTextWithShareUtils(this);
+            NewPipeTextViewHelper.shareSelectedTextWithShareUtils(this);
+            return true;
         }
         return super.onTextContextMenuItem(id);
     }