Crash when running two newpipe instances at the same time: java.lang.RuntimeException: Error receiving broadcast intent…

[B0pol]

Checklist

• I am using the latest version - 0.20.1
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

• (optional?) uninstall all newpipe apps
• install newpipe 0.20.1
• install a newpipe debug version, to have multiple newpipes at the same time
• open a video

Actual behaviour

Crash

Expected behavior

Everything works fine

Logs

Exception

• User Action: ui error
• Request: App crash, UI failure
• Content Country: FR
• Content Language: fr-FR
• App Language: fr_FR
• Service: none
• Version: 0.20.1
• OS: Linux Android 9 - 28

Crash log

java.lang.RuntimeException: Error receiving broadcast Intent { act=org.schabi.newpipe.VideoDetailFragment.ACTION_PLAYER_STARTED flg=0x10 } in org.schabi.newpipe.fragments.detail.VideoDetailFragment$4@4feadd9
	at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0(LoadedApk.java:1401)
	at android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA.run(Unknown Source:2)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6718)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Caused by: java.lang.IllegalStateException: Not allowed to start service Intent { cmp=org.schabi.newpipe/.player.MainPlayer }: app is in background uid UidRecord{1b3bf85 u0a590 CAC  bg:+2m34s765ms idle procs:1 seq(0,0,0)}
	at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1577)
	at android.app.ContextImpl.startService(ContextImpl.java:1532)
	at android.content.ContextWrapper.startService(ContextWrapper.java:664)
	at org.schabi.newpipe.player.helper.PlayerHolder.startService(PlayerHolder.java:59)
	at org.schabi.newpipe.fragments.detail.VideoDetailFragment$4.onReceive(VideoDetailFragment.java:1343)
	at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0(LoadedApk.java:1391)
	... 8 more

---

Device info

• Android version/Custom ROM version: Android 9
• Device model: Pocophone F1

[Stypox]

I don't think we should put any effort into fixing this. Usually users do not have multiple NewPipes

[opusforlife2]

Also, this conflict doesn't happen between two release builds. At least one of them has to be a debug build.

@Stypox But testers do have multiple Newpipes. And testing often involves comparing differences between them, especially when videos are playing. Testing would become absolute hell if I had to test one build, close it, then open the other and then test it, back and forth, back and forth.

So to me this isn't low priority at all. Medium priority at least. :P

[opusforlife2]

Or developers would have to ensure they're uploading release builds.

[opusforlife2]

A debug build doesn't cause problems when used alongside a pre-0.20.0 debug build. So there is definitely something in the new version. My guess is the notification code, since that also seems to cause other problems as users have noted.

[B0pol]

I don't think we should put any effort into fixing this. Usually users do not have multiple NewPipes

When they test, they do. When they install a debug apk which fixes newpipe (right now), they do.

[XiangRongLin]

I have a similar problem too. when running multiple debug builds and having their notification present. if you close one, then start playing on the other, the closed one appears again.

I remember seeing in the code somewhere a hardcoded ID for broadcast (or something similar) towards the notifications. With multiple apps they would all them receive it.

Edit:

NewPipe/app/src/main/java/org/schabi/newpipe/player/NotificationUtil.java

Line 46 in dfd6424

private static final int NOTIFICATION_ID = 123789;

[avently]

All broadcasts should use package name instead of hardcoded strings

[B0pol]

Not to mention the related bugs: if you pause one NewPipe, the other one will resume. If you delete the notification from one NewPipe, the other one will delete notification too

[B0pol]

I have a similar problem too. when running multiple debug builds and having their notification present. if you close one, then start playing on the other, the closed one appears again.

I remember seeing in the code somewhere a hardcoded ID for broadcast (or something similar) towards the notifications. With multiple apps they would all them receive it.

Edit:

NewPipe/app/src/main/java/org/schabi/newpipe/player/NotificationUtil.java

Line 46 in dfd6424

private static final int NOTIFICATION_ID = 123789;

The actual reason is because package name isn't org.schabi.newpipe on debug builds.

NewPipe/app/src/main/java/org/schabi/newpipe/player/MainPlayer.java

Lines 66 to 85 in 1b47a1a

	static final String ACTION_CLOSE
	= "org.schabi.newpipe.player.MainPlayer.CLOSE";
	static final String ACTION_PLAY_PAUSE
	= "org.schabi.newpipe.player.MainPlayer.PLAY_PAUSE";
	static final String ACTION_OPEN_CONTROLS
	= "org.schabi.newpipe.player.MainPlayer.OPEN_CONTROLS";
	static final String ACTION_REPEAT
	= "org.schabi.newpipe.player.MainPlayer.REPEAT";
	static final String ACTION_PLAY_NEXT
	= "org.schabi.newpipe.player.MainPlayer.ACTION_PLAY_NEXT";
	static final String ACTION_PLAY_PREVIOUS
	= "org.schabi.newpipe.player.MainPlayer.ACTION_PLAY_PREVIOUS";
	static final String ACTION_FAST_REWIND
	= "org.schabi.newpipe.player.MainPlayer.ACTION_FAST_REWIND";
	static final String ACTION_FAST_FORWARD
	= "org.schabi.newpipe.player.MainPlayer.ACTION_FAST_FORWARD";
	static final String ACTION_SHUFFLE
	= "org.schabi.newpipe.player.MainPlayer.ACTION_SHUFFLE";
	public static final String ACTION_RECREATE_NOTIFICATION
	= "org.schabi.newpipe.player.MainPlayer.ACTION_RECREATE_NOTIFICATION";