Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited time support for v0.19.8 #4918

Open
XiangRongLin opened this issue Nov 19, 2020 · 35 comments
Open

Limited time support for v0.19.8 #4918

XiangRongLin opened this issue Nov 19, 2020 · 35 comments
Labels
meta Related to the project but not strictly to code

Comments

@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Nov 19, 2020

I would be willing to provide a limited time support for NewPipe v0.19.8 while the issues with the new UI get addressed and I myself am comfortable to switch over. It would only contain updating the extractor version and fixing things if the public API of the extractor changes. No bugfixes specific to NewPipe and not NewPipeExtractor.
Unless there are major changes in the extractor this would be ok for me since i plan to use it myself.


NewPipe and NewPipe Legacy.

https://github.com/XiangRongLin/NewPipe-preuinified/releases/

Legacy needs confirmation that it actually works


previous versions

NewPipe v0.19.8 and Extractor v0.20.7
app-release.zip


NewPipe v0.19.8 and Extractor v0.20.6
app-release.zip

XiangRongLin@0feef16


NewPipe v0.19.8 and Extractor v0.20.5 with notification fixes for Android 11
app-release.zip

XiangRongLin@aa55a09


NewPipe v0.19.8 and Extractor v0.20.5
app-release.zip

XiangRongLin@4bca8f4


NewPipe v0.19.8 and Extractor v0.20.4 with desugar/multidex changes for old devices
app-release.zip

XiangRongLin@d3fe372


Release build with NewPipe v0.19.8 and Extractor v0.20.3
app-debug.zip
app-release.zip

XiangRongLin@e00a706


Debug build with NewPipe v0.19.8 and Extractor v0.20.2
app-debug.zip
The changes needed for this are: XiangRongLin@e00a706


previous legacy versions

NewPipe legacy v0.19.8 and Extractor v0.20.5 (needs confirmation thats it works on Android < 4.1)
app-release.zip

https://github.com/XiangRongLin/NewPipe-legacy/commit/7e150a64b52d1e6e19774133589c157589a33022

@XiangRongLin XiangRongLin added the feature request Issue is related to a feature in the app label Nov 19, 2020
@opusforlife2 opusforlife2 pinned this issue Nov 19, 2020
@Wahbam
Copy link

Wahbam commented Nov 19, 2020

Thank you. 0.20.2 and 0.20.3 have been next to impossible to use for me due to constant crashes. Your debug build so far seems to work. Your 0.19.8 release build, however, for me fails to load any videos at all in search, trending, or (imported) subscription lists.

@kubo6472

This comment has been minimized.

@XiangRongLin
Copy link
Collaborator Author

@Wahbam

Thank you. 0.20.2 and 0.20.3 have been next to impossible to use for me due to constant crashes. Your debug build so far seems to work. Your 0.19.8 release build, however, for me fails to load any videos at all in search, trending, or (imported) subscription lists.

I can't really help you there. I generated the apks again and updated my post above.

@kubo6472
Also, can the "clear CAPTCHA cookies" option from 0.20.3 be added back into "content" tab. I have issues since it doesn't load.

no new features are getting backported

@kubo6472
Copy link

kubo6472 commented Nov 19, 2020

no new features are getting backported

Aight, I understand.

@kubo6472
Copy link

I can't really help you there. I generated the apks again and updated my post above.

The regenerated apk suddenly works no problem.

@MD77MD
Copy link

MD77MD commented Nov 19, 2020

Although i don't plane to use it myself. this is very needed.

Thank you @XiangRongLin

@opusforlife2 opusforlife2 added meta Related to the project but not strictly to code and removed feature request Issue is related to a feature in the app labels Nov 19, 2020
@triallax
Copy link
Contributor

How is this any different from #4686?

@kubo6472
Copy link

How is this any different from #4686?

That the OA is the one who provided solution in that mentioned FR. This is just a separate issue to be pinned alone

@opusforlife2
Copy link
Collaborator

Good point. This isn't a PR, but it 'fixes' that issue.

@opusforlife2
Copy link
Collaborator

@eladkarako Your repo has no sources at all. You do know that it's illegal to distribute the binary without the source, right?

@kapodamy
Copy link
Contributor

kapodamy commented Nov 20, 2020

TL;TR the pre-unified version is not compatible with older devices.

Update the app/build.gradle file and include:

in the v0.19.8 version. because the lastest extractor aims the sdk v26 (android 8), See TeamNewPipe/NewPipeExtractor#417.

edit: ¡the release apk is not signed!. wont install unless it is regenerated

@BlueAmulet
Copy link

I'm also unable to use this pre-unified version due to the lack of desugaring, if those commits could be added that would be appreciated.

@XiangRongLin

@XiangRongLin
Copy link
Collaborator Author

@kapodamy I can't get it to work by just cherry picking those 2 commits and merging them. I get an error when opening a video on api 19 emulator, that i won't make the effort to understand.

XiangRongLin@d3d1888

@kapodamy
Copy link
Contributor

kapodamy commented Nov 28, 2020

@XiangRongLin I added those commits and also made other changes (update kotlin) that I should have told you. I did a pr with the missing changes
XiangRongLin#3

@XiangRongLin
Copy link
Collaborator Author

@kapodamy I can't get it to work on the API 19 emulator with your changes. Is it something specific to the emulator?

@kubo6472
Copy link

kubo6472 commented Nov 29, 2020

@kapodamy I can't get it to work on the API 19 emulator with your changes. Is it something specific to the emulator?

API 19 sounds a bit old, that may be caused by the JDK bump, since from what I found, they recommend JDK6 for widest compatibility on Android. @XiangRongLin

@XiangRongLin
Copy link
Collaborator Author

API 19 sounds a bit old, that may be caused by the JDK bump, since from what I found, they recommend JDK6 for widest compatibility on Android.

Im using it because its the minSDK of the project @kubo6472

@kapodamy
Copy link
Contributor

kapodamy commented Nov 29, 2020

@XiangRongLin i tested on 3 kitkat devices and works fine. Im getting this issue #4957 only in the emulator.
VirtualBox_andoid 4 4_29_11_2020_14_10_18
theres my build (but includes updates 3rd party libraries like exoplayer) wich i tested in the emulator and physical devices
org.schabi.newpipe.preunified-1.zip

@Isira-Seneviratne
Copy link
Member

Isira-Seneviratne commented Nov 30, 2020

@kapodamy I can't get it to work on the API 19 emulator with your changes. Is it something specific to the emulator?

API 19 sounds a bit old, that may be caused by the JDK bump, since from what I found, they recommend JDK6 for widest compatibility on Android. @XiangRongLin

Desugaring backports the JDK 8 types (the date/time API) for use on older versions of Android.

@Isira-Seneviratne
Copy link
Member

@XiangRongLin i tested on 3 kitkat devices and works fine. Im getting this issue #4957 only in the emulator.
VirtualBox_andoid 4 4_29_11_2020_14_10_18
theres my build (but includes updates 3rd party libraries like exoplayer) wich i tested in the emulator and physical devices
org.schabi.newpipe.preunified-1.zip

Commit eb1cddd might fix this issue.

@XiangRongLin
Copy link
Collaborator Author

i tested on 3 kitkat devices and works fine. Im getting this issue #4957 only in the emulator.

@kapodamy ok, then its just the emulator.
Also the reason for the apk not being signed could be because I only checked the v2 box when creating it. Now its with v1 and v2.

I updated my post with your changes.

@BlueAmulet fyi

@nbmrjuhneibkr
Copy link

nbmrjuhneibkr commented Dec 3, 2020

Sadly, this build can't be used on Android 11, because old background player notification is completely broken there. So now I'm stuck with v0.20 (which hasn't been updated on F-Droid since 0.20.1, by the way). I had to stop using NewPipe for anything other than background playback (the only feature that isn't frustrating to use in 0.20, yet), and have no choice but to use a regular web browser for anything else.

I never thought that such a great app could become so useless so quickly. Thanks for keeping it alive on earlier Android versions, at least.

@rikishi0071
Copy link

rikishi0071 commented Dec 3, 2020

@XiangRongLin is it possible to build NewPipe Legacy 0.19.8 (Android 4.1) with NewPipe Extractor 0.20.x or not?

@XiangRongLin
Copy link
Collaborator Author

@rikishi0071 I just cherry-picked all commits.
You'll have to hope that it works since i don't have a hardware device to test it in any way. And emulator doesnt work.

app-release.zip
https://github.com/XiangRongLin/NewPipe-legacy/commit/7e150a64b52d1e6e19774133589c157589a33022

@BlueAmulet
Copy link

I get the same crash that happens in emulator, I'm running an Android Nougat 7.1 device

@XiangRongLin
Copy link
Collaborator Author

@nbmrjuhneibkr lucky you that i have android 11 too. check out the new apk at the top

@nbmrjuhneibkr
Copy link

@XiangRongLin it works now, thank you!

@kubo6472
Copy link

I just wanted to really thank you for this one. For more than a month, I haven't had any issues with your builds, and didn't have to worry that suddenly these and these videos wouldn't play. This is as close to a finished app experience I can imagine. Since it's built on the old system everyone is used to, and just the backend is being adjusted, no big sudden changes, less stuff that can break etc. I appreciate the work guys did on the unified player, and how hard they worked on fixing everything, but that philosophically breaks use cases. Nvm, thanks again a have a nice Christmas eve day.

@hipunk
Copy link

hipunk commented Dec 30, 2020

Thank you, works great.

@Isira-Seneviratne
Copy link
Member

@XiangRongLin I created a PR for your fork of NewPipe Legacy.

@nbmrjuhneibkr
Copy link

Thanks for the continuous updates. Seeing how little has been done to fix some of the terrible design decisions in NewPipe 0.20, I feel like this fork will stay relevant for quite some time.

@nikhilCad
Copy link

nikhilCad commented Feb 1, 2021

Months fly by, but v0.20 remains without option to stop autoplay, or playing in landscape without rotating phone.

@XiangRongLin
Copy link
Collaborator Author

I created a repo where i'll upload the releases from now on. So it's possible to just watch the releases of that repo in order to get notified.

https://github.com/XiangRongLin/NewPipe-preuinified/releases/

@Multipanda
Copy link

Thank you so much, the new UI has become more of a pain with each update so far, and unless they add an option to turn off the unified player I guess I will stick with your version as long as I can. :-)

@Pavlecom
Copy link

Thank you for your work !! ... 👍👍✨

cweiske pushed a commit to ouya-saviors/ouya-game-data that referenced this issue Mar 12, 2022
Currently, the project is a fork of the original NewPipe Legacy which doesn't receive updates since 01/10/2021.

Project's original page: https://github.com/TeamNewPipe/NewPipe-legacy
Issue opened on the original project: TeamNewPipe/NewPipe#4918
Fork's page: https://github.com/XiangRongLin/NewPipe-preuinified

Changes:

- Included notes on technical instructions;
- Changed the link of the images to the jpg versions;
- Changed information about developer, website and others.

Tested and working.
cweiske pushed a commit to ouya-saviors/ouya-game-data that referenced this issue Mar 12, 2022
Currently, the project is a fork of the original NewPipe Legacy which doesn't receive updates since 01/10/2021.

Project's original page: https://github.com/TeamNewPipe/NewPipe-legacy
Issue opened on the original project: TeamNewPipe/NewPipe#4918
Fork's page: https://github.com/XiangRongLin/NewPipe-preuinified

Changes:

- Included notes on technical instructions;
- Changed the link of the images to the jpg versions;
- Changed information about developer, website and others.

Tested and working.

Resolves: #145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

No branches or pull requests