Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking YouTube video TimeStamps on Video description and Comment Section shows different behaviour #5507

Closed
4 tasks done
skyGtm opened this issue Jan 30, 2021 · 3 comments · Fixed by #5523
Closed
4 tasks done
Labels
bug Issue is related to a bug

Comments

@skyGtm
Copy link

skyGtm commented Jan 30, 2021

Checklist

Steps to reproduce the bug

  1. Go to any YouTube video
  2. Press on Time Stamp @ video description
  3. Press Time Stamp @ video comment (if available)

Actual behaviour

clicking TimeStamp on video description --> opens Action Picker
clicking TimeStamp on video comment --> opens Popup player

Expected behavior

For now, I think it will be good to open Popup player in both cases.
Because some videos has long description and long comment list.
(i am telling it, because you( developers ) may have future plan to open timestamp in Main Player but i prefer a popup player
for description timestamp also)

Also, I like to mention that I know new version of NewPipe now support stream segments #5274 for description based timestamps.
But I also prefer to click timestamps available at video description.

Screenshots/Screen recordings

Screenshot_2021-01-30-10-14-32

Screenshot_2021-01-30-10-15-46

Logs

Device info

  • Android version/Custom ROM version:
  • Device model:
@demonff1
Copy link

demonff1 commented Feb 4, 2021

I think it would be better to have customization on whether pop up player or main player. It should be left to the user end.
Personally I'd love the main player like the YouTube app tho 🙃

@Kohoshi12
Copy link

Maybe the timestamp should just follow the format the user is already using: main, audio or pop-up. It'll complicate the settings more than it's if that's the case.

@AudricV
Copy link
Member

AudricV commented Mar 16, 2021

The timestamps will be recognized by #5523 and will open the popup player when clicked like for comments (don't ask me to change the action, I don't have the knowledge to do it, so you will to wait that another person creates a PR for this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants