Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.20.10 #5455

Closed
13 of 14 tasks
TobiGr opened this issue Jan 18, 2021 · 70 comments · Fixed by #5523
Closed
13 of 14 tasks

Release 0.20.10 #5455

TobiGr opened this issue Jan 18, 2021 · 70 comments · Fixed by #5523

Comments

@TobiGr
Copy link
Member

TobiGr commented Jan 18, 2021

Changelogs

App

New

Improved

Fixed

Development

Localization

Extractor

New

Improved

Fixed

Development

TODO

APK for testing

NewPipe_v0.20.9_RC7.zip

Corresponding PR: #5456

@TobiGr TobiGr pinned this issue Jan 18, 2021
@Stypox
Copy link
Member

Stypox commented Jan 18, 2021

@nadiration for me it works as expected. Probably your screen is too small to host two columns of grid items. Does everything work as expected if you rotate the device?

@TobiGr
Copy link
Member Author

TobiGr commented Jan 18, 2021

NewPipe_v0.20.9_RC2.zip includes a fix for a crash that happened when sharing streams to the browser and no browser was installed (e.g. on ANdroid TVs) #5429

@skyGtm
Copy link

skyGtm commented Jan 19, 2021

In popup mode, on dragging the popup to the bottom, the RED close button appears for instant and disappears, close action is also not performed.
In NewPipe version 20.8 (works as expected)

version.20.8.mp4

In NewPipeVersion 20.9_RC2(doesn't work as expected)

version.20.9_RC2.mp4

@Poolitzer
Copy link
Member

@Stypox, not sure if thats out of the scope with this release, but what about letting the tab icons vanish or at least make them smaller when scrolling down, and enlarge/letting them reappear when scrolling up? I think that's the default in android apps, at least from my experience. That way you see more of the comments/videos/description without loosing the ability to navigate.

@Stypox
Copy link
Member

Stypox commented Jan 19, 2021

@skyGtm that seems like to be the correct behaviour. It wasn't working before and 920e560 fixed it. The current expected behaviour is for the button to be visible only when your finger is near it. But I agree that's not the best idea, I'm going to push a fix soon

@triallax
Copy link
Contributor

triallax commented Jan 19, 2021

On my Android 6 device, whenever I try to extract the APK from the ZIP archive, I get the following error:

There was an error extracting the file into "Download".
java.io.IOException: Size mismatch on inflated file: 13151759 vs 13151751

However, it works fine on my Android 10 device.

Edit: downloading the archive directly works. Seems like it won't work when transferring between devices using Bluetooth.

@TobiGr
Copy link
Member Author

TobiGr commented Jan 19, 2021

I tried to reproduce a different bug and got this:

Exception

Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Could not find videoSecondaryInfoRenderer
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getVideoSecondaryInfoRenderer(YoutubeStreamExtractor.java:914)
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getAgeLimit(YoutubeStreamExtractor.java:246)
	at org.schabi.newpipe.extractor.stream.StreamInfo.extractImportantData(StreamInfo.java:106)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:71)
	at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:64)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:128)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$YTHJjScxCJNO1LTCqs3IKy35iyY.call(Unknown Source:4)
	at io.reactivex.rxjava3.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:43)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42)
	at io.reactivex.rxjava3.core.Flowable.subscribe(Flowable.java:15753)
	at io.reactivex.rxjava3.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36)
	at io.reactivex.rxjava3.core.Maybe.subscribe(Maybe.java:5330)
	at io.reactivex.rxjava3.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.rxjava3.core.Scheduler$DisposeTask.run(Scheduler.java:614)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:764)


@AudricV
Copy link
Member

AudricV commented Jan 19, 2021

There is something strange when clicking links at the top of a description after the secondary controls PR, see issue #5453.

@Stypox
Copy link
Member

Stypox commented Jan 19, 2021

@Stypox, not sure if thats out of the scope with this release, but what about letting the tab icons vanish or at least make them smaller when scrolling down, and enlarge/letting them reappear when scrolling up? I think that's the default in android apps, at least from my experience. That way you see more of the comments/videos/description without loosing the ability to navigate.

Currently the tab layout is only visible when the visible part of the tab is at least 96dp (i.e. twice the height of the tab layout itself), so it isn't that much in the way even when the rest of the screen is used up by video player and controls. Anyway, I agree that we should implement Android's default way of handling hiding tab layouts in the future. Though it could be nasty to implement due to the many things that could trigger a scroll.

@Timmy183-ui
Copy link

Timmy183-ui commented Jan 19, 2021

When you set view mode to grid (Settings > Appearance > List view mode) it doesn't really switch to grid but to a large list-like mode. This was working fine before on portrait orientation, now i have the two versions (0.20.8 and 0.20.9 RC1) side by side and it's something with this version because v0.20.8 is working as expected.

List view mode: Grid

Any fix for this? It's not a good implementation of grid view

@brnwlshubh
Copy link

brnwlshubh commented Jan 19, 2021

On updating the Channel group. App crashes by the following report:-

Exception

  • User Action: ui error
  • Request: App crash, UI failure
  • Content Country: IN
  • Content Language: en-GB
  • App Language: en_GB
  • Service: none
  • Version: 0.20.9
  • OS: Linux samsung/on7xeltedd/on7xelte:8.1.0/M1AJQ/G610FDDU1CSK2:user/release-keys 8.1.0 - 27
Crash log

java.lang.NullPointerException: Attempt to read from field 'androidx.appcompat.widget.AppCompatButton org.schabi.newpipe.databinding.ChannelHeaderBinding.channelSubscribeButton' on a null object reference
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.lambda$getSubscribeUpdateMonitor$8$ChannelFragment(ChannelFragment.java:341)
	at org.schabi.newpipe.fragments.list.channel.-$$Lambda$ChannelFragment$vmiMdrHAJhwZ8mwsJJh23kG8lqY.accept(Unknown Source:6)
	at io.reactivex.rxjava3.internal.observers.LambdaObserver.onNext(LambdaObserver.java:63)
	at io.reactivex.rxjava3.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.drainNormal(ObservableObserveOn.java:201)
	at io.reactivex.rxjava3.internal.operators.observable.ObservableObserveOn$ObserveOnObserver.run(ObservableObserveOn.java:255)
	at io.reactivex.rxjava3.android.schedulers.HandlerScheduler$ScheduledRunnable.run(HandlerScheduler.java:123)
	at android.os.Handler.handleCallback(Handler.java:790)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:7000)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:441)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1408)


@nadiration
Copy link
Contributor

The popup closing button (x) is gone

@triallax
Copy link
Contributor

@nadiration see #5458.

@TobiGr
Copy link
Member Author

TobiGr commented Jan 22, 2021

NewPipe_v0.20.9_RC3.zip fixes the popup closing regression and the feed refresh status message.

@brnwlshubh
Copy link

brnwlshubh commented Jan 22, 2021

NewPipe_v0.20.9_RC3.zip fixes the popup closing regression and the feed refresh status message.

This package has still #5464 crash issue.

@triallax
Copy link
Contributor

@brnwlshubh yes, that's expected, as #5464 has still not been merged.

@alienthief
Copy link

alienthief commented Jan 22, 2021

@TobiGr could you pull updated translations (weblate) from the last two days before 0.20.9 public release?

@skyGtm skyGtm mentioned this issue Jan 22, 2021
3 tasks
@opusforlife2
Copy link
Collaborator

@alienthief That's always the last step before release, don't worry.

@alienthief
Copy link

@opusforlife2 i know that but since he updated translation from like 5 days ago, i was talking about the most recent ones like two or three days ago

@opusforlife2
Copy link
Collaborator

@alienthief What I mean is that the translations will always be synced again just before the release is tagged. Look at the TODO in the OP. It's second last on the list.

@Orion983

This comment has been minimized.

@triallax

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@Orion983

This comment has been minimized.

@opusforlife2

This comment has been minimized.

@TobiGr
Copy link
Member Author

TobiGr commented Jan 30, 2021

NewPipe_v0.20.9_RC5.zip

  • [YouTube Music] Fix extracting search item view/subscriber count when it equals zero
  • Set all default settings at the beginning

@alienthief

This comment has been minimized.

@triallax

This comment has been minimized.

@TobiGr
Copy link
Member Author

TobiGr commented Jan 31, 2021

NewPipe_v0.20.9_RC6.zip fixes a bug that prevented NewPipe to fall back to Google Play Store URL when using InstallApp method (e.g. for Kodi or VLC installation)

@ghost
Copy link

ghost commented Feb 1, 2021

Was watching a video with rc6 double tapped to seek, NewPipe crashed, also sometimes unable to change video quality while watching

@AudricV
Copy link
Member

AudricV commented Feb 1, 2021

NewPipe_v0.20.9_RC6.zip fixes a bug that prevented NewPipe to fall back to Google Play Store URL when using InstallApp method (e.g. for Kodi or VLC installation)

Note that there is a small bug which shows the toast No app on your device can open this if no app can handle the market scheme when the system chooser to open a web browser or the default browser is opened. I fixed it in #5523.

@TobiGr
Copy link
Member Author

TobiGr commented Feb 3, 2021

NewPipe_v0.20.9_RC7.zip

  • Fixed YouTube stream chapters
  • Fixed channel subscribe button causing crash on closing
  • Reduce requests to NewPipe API when checking for new version
  • updated translations

@alienthief
Copy link

Since description scrolling is caused by "secondry controls" which many of us don't like plus it took over description's place can we like revert it since it's blocking and seems unsolvable?

@romanstingler
Copy link

not per se an issue but it would be nice to have the -rcX in the version number of the app (in about and menu).
furthermore, it would be great to have a selectable testing repo with all the rc versions so the development versions would get updated automatically.

@nadiration
Copy link
Contributor

When opening age-restricted videos by default 'show age-restricted content' is disabled on the app so when you open a restricted video it tells you to enable 'show age-restricted content' on settings, now when you enable that option with a restricted video loaded on the player the menus get overlapped and comments/description don't show up.

To reproduce:

  1. Open age-resticted video (any video for example https://www.youtube.com/watch?v=EX_8ZjT2sO4)
  2. The player will tell you to enable age-restricted video
  3. Now with the video on the player go to settings and enable show restricted videos Settings > Content
  4. Come back to the video and see how the player acts

*Workaround: close the player from the recent apps and reopen the video, it will work as expected.

Context:
Screenshot_20210207-215835

@Stypox
Copy link
Member

Stypox commented Feb 12, 2021

@nadiration could you test #5563?

@B0pol B0pol changed the title Release 0.20.9 Release 0.20.10 Feb 12, 2021
@TeamNewPipe TeamNewPipe deleted a comment from DamnItB0pol Feb 12, 2021
@Orion983
Copy link

Wait I thought it was 0.20.9 wha-

@Orion983
Copy link

Is this a joke

@nadiration
Copy link
Contributor

nadiration commented Feb 12, 2021

@Stypox the layout problem is gone but could you make the play button to refresh the video since now when you go and enable restricted content on settings and come back to the video it doesn't [auto] refesh and the play button (on the minimized video) does nothing thus requiring you to close the video then you have to find the video again and play.

@romanstingler
Copy link

@Stypox
Copy link
Member

Stypox commented Feb 13, 2021

@nadiration that's not a regression and as such will not be fixed here

@nadiration

This comment has been minimized.

@Orion983

This comment has been minimized.

@triallax
Copy link
Contributor

triallax commented Feb 14, 2021

To those wondering why this release was changed to 0.20.10, it's because there was a bug where you can't load more videos in the channel page (#5550), and since this is a big bug and this release was taking a while, we decided to release 0.20.9 with the hotfix for that bug. 0.20.10 has NOT been postponed. It is still going to come soon.

@Orion983

This comment has been minimized.

@nadiration

This comment has been minimized.

@triallax

This comment has been minimized.

@triallax
Copy link
Contributor

@HTSamurai quoting @Stypox:

Please don't ask, obviously it is releasing soon: it will be released when it will be ready. As you can see at top there are still some TODOs left, which mostly fix regressions, after those it will be released.

@TobiGr TobiGr closed this as completed Feb 14, 2021
@TobiGr TobiGr unpinned this issue Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.