Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some simplified Chinese translations in app are not consistent with source code #6469

Closed
4 tasks done
Geeyun-JY3 opened this issue Jun 10, 2021 · 7 comments
Closed
4 tasks done
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate

Comments

@Geeyun-JY3
Copy link
Contributor

Checklist

Steps to reproduce the bug

e.g. Setting > Video and audio > Behavior
Fast-forward/-rewind seek duration is still translated into 快进 / 快退的单位时间, not the lastest 快进 / 快退的寻址定位时间间隔

Actual behaviour

Some simplified Chinese translations in app are not consistent with https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/res/values-b%2Bzh%2BHANS%2BCN/strings.xml
Although the https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/res/values-b%2Bzh%2BHANS%2BCN/strings.xml is consistent with the translations on Weblate, some translations in app are still not updated.

Expected behavior

Translations are consistent with https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/res/values-b%2Bzh%2BHANS%2BCN/strings.xml

Screenshots/Screen recordings

Nope

Device info

  • Android version/Custom ROM version: Android 9 MIUI 10 9.9.3
  • Device model: Mi 8
@Geeyun-JY3 Geeyun-JY3 added the bug Issue is related to a bug label Jun 10, 2021
@triallax triallax added the localisation / translation Everything that has to do with translations or Weblate label Jun 15, 2021
@triallax
Copy link
Contributor

Please try the APK from the latest run (it's at the bottom); can you reproduce the issue there?

This is odd, as I checked and found that particular translation to be in master. Was the release APK built from an older commit perhaps?

@Geeyun-JY3
Copy link
Contributor Author

Please try the APK from the latest run (it's at the bottom); can you reproduce the issue there?

Tested. Still can reproduce.

@Geeyun-JY3
Copy link
Contributor Author

Geeyun-JY3 commented Oct 19, 2021

Oh I find the reason. The Simplified Chinese translation of current version NewPipe is consistent with https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/res/values-zh-rCN/strings.xml. But the latest translation would only push to https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/res/values-b%2Bzh%2BHANS%2BCN/strings.xml.
Weblate also has a Duplicated translation. alert in Strings component for this.
image

Maybe the values-zh-rCN file should be removed.

@Geeyun-JY3
Copy link
Contributor Author

Geeyun-JY3 commented Oct 25, 2021

It's been 2 years since Weblate firstly made an alert for this issue. The duplicate language file must be removed. There should be only one language file for simplified Chinese.

@Geeyun-JY3
Copy link
Contributor Author

Related: WeblateOrg/weblate#7312

@Geeyun-JY3
Copy link
Contributor Author

Defacto duplicate of #2819. But #2819 is defacto not fixed yet.

@triallax
Copy link
Contributor

Should have been fixed by #8549. Please leave a comment if the issue is still present (note that the fix hasn't landed in any release yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

No branches or pull requests

2 participants