Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source strings consistency improvement: avoid using append #7425

Closed
4 tasks done
Geeyun-JY3 opened this issue Nov 19, 2021 · 1 comment
Closed
4 tasks done

Source strings consistency improvement: avoid using append #7425

Geeyun-JY3 opened this issue Nov 19, 2021 · 1 comment
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate

Comments

@Geeyun-JY3
Copy link
Contributor

Geeyun-JY3 commented Nov 19, 2021

Checklist

I made a comment on Weblate but nobody reacts to it😑. So I file an issue here.

Steps to reproduce the bug

Just about source string.

Actual behavior

Source string including append:
Used in Settings > Appearance > Show "Hold to append" tip option
Show "Hold to append" tip

<string name="show_hold_to_append_title">Show \"Hold to append\" tip</string>

But the corresponding string is Hold to enqueue.

<string name="hold_to_append">Hold to enqueue</string>


Used in Settings > Video and audio > Auto-queue next stream option

<string name="auto_queue_summary">Continue ending (non-repeating) playback queue by appending a related stream</string>

Expected behavior

Use enqueue instead
Hold to enqueue

<string name="hold_to_append">Hold to enqueue</string>

BTW, #6469 needs attention. The duplicate Simplified Chinese translation should be removed: #6469 (comment)

Screenshots/Screen recordings

Logs

Device info

  • Android version/Custom ROM version: Android 9 MIUI 10 9.9.3
  • Device model: Mi 8
@Geeyun-JY3 Geeyun-JY3 added the bug Issue is related to a bug label Nov 19, 2021
@triallax triallax added the localisation / translation Everything that has to do with translations or Weblate label Nov 20, 2021
@Geeyun-JY3
Copy link
Contributor Author

Fixed in Weblate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

No branches or pull requests

2 participants