Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Serbian README #10465

Merged
merged 20 commits into from
Oct 2, 2023
Merged

Create Serbian README #10465

merged 20 commits into from
Oct 2, 2023

Conversation

nemanya-d
Copy link
Contributor

@nemanya-d nemanya-d commented Oct 1, 2023

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Added translation of the README into Serbian.

Due diligence

@AudricV AudricV changed the title Create README.sr.md Create Serbian README Oct 1, 2023
@AudricV AudricV added meta Related to the project but not strictly to code localisation / translation Everything that has to do with translations or Weblate labels Oct 1, 2023
@nemanya-d nemanya-d closed this Oct 1, 2023
@nemanya-d nemanya-d deleted the patch-1 branch October 1, 2023 18:40
@nemanya-d nemanya-d restored the patch-1 branch October 1, 2023 18:43
@nemanya-d nemanya-d reopened this Oct 1, 2023
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Link the Serbian file in the other translated READMEs, too please.

@nemanya-d
Copy link
Contributor Author

Thank you. Link the Serbian file in the other translated READMEs, too please.

You're welcome!

Note: I needed to make a separate commit for the all READMEs, I'm not that experienced on GitHub haha.

@nemanya-d nemanya-d requested a review from TobiGr October 2, 2023 01:20
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, We will take care of the commits later when merging this PR. Many images have relative URLs which need to be fixed.

doc/README.sr.md Outdated Show resolved Hide resolved
doc/README.sr.md Outdated Show resolved Hide resolved
@nemanya-d
Copy link
Contributor Author

Thanks, We will take care of the commits later when merging this PR. Many images have relative URLs which need to be fixed.

Done. Thanks for the help!

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@TobiGr TobiGr merged commit d63a6d3 into TeamNewPipe:dev Oct 2, 2023
2 of 3 checks passed
@nemanya-d
Copy link
Contributor Author

nemanya-d commented Oct 2, 2023

thanks!

Hey, I just noticed that I didn't fix URLs for images in the "Donate" section. Forgot to replace with ../assets/. Fix that please, if that's possible

@TobiGr
Copy link
Member

TobiGr commented Oct 2, 2023

done

@nemanya-d
Copy link
Contributor Author

nemanya-d commented Oct 2, 2023

done

That was fast, thank you!

Unrelated to this PR

I noticed that there is no Russian translation of the README linked in any of the READMEs, I don't know if there is a reason for that, but I just wanted to let you know that.

Edit: I'm not sure, but maybe there are missing links to some other translations as well, keep that in mind.

javulticat pushed a commit to NewPipeX/NewPipeX that referenced this pull request Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants