Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes crash when a file is deleted then redownloaded #3794

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Fixes crash when a file is deleted then redownloaded #3794

merged 1 commit into from
Sep 9, 2020

Conversation

budde25
Copy link
Contributor

@budde25 budde25 commented Jun 19, 2020 •
edited
Loading

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Adds a null check before a String comparison on the equals method
  • Fixes bug where downloading the same deleted file would cause the app to crash on a NullPointerException

Fixes the following issue(s)

Testing apk

debug.zip

Agreement

@TobiGr TobiGr added bug Issue is related to a bug downloader Issue is related to the downloader labels Jun 21, 2020
Stypox
Stypox approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you did looks reasonable, sorry for not reaching out before. Thank you :-D

@Stypox Stypox merged commit 2215ce5 into TeamNewPipe:dev Sep 9, 2020
This was referenced Sep 27, 2020
Closed
Merged
@opusforlife2 opusforlife2 mentioned this pull request Apr 2, 2021
Merged
14 tasks
ShareASmile pushed a commit to ShareASmile/NewPipeZing that referenced this pull request Aug 16, 2021
@Stypox @ShareASmile
Merge pull request TeamNewPipe#3794 from budde25/download-same-file-c…
0797e38 
…rash

Fixes crash when a file is deleted then redownloaded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

@Grandolf49 Grandolf49 Grandolf49 approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug downloader Issue is related to the downloader
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoNonsense-File-Picker: Crash when a file is deleted and redownloaded
4 participants
@budde25 @Grandolf49 @Stypox @TobiGr