Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations improvements #4310

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Translations improvements #4310

merged 2 commits into from
Sep 24, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Sep 22, 2020

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fixes the following issue(s)

Testing apk

app-debug.zip

Agreement

@B0pol B0pol added the localisation / translation Everything that has to do with translations or Weblate label Sep 22, 2020
@B0pol B0pol force-pushed the duplicate branch 2 times, most recently from 95fb3f6 to 8838998 Compare September 22, 2020 19:46
- remove duplicated string (name) and avoid potential duplicate (autoplay_never_description -> Never, autoplay_always_description -> Always because they are just "Always" or "Never"). Fixes TeamNewPipe#4268
- leakCanary string removed (fixes TeamNewPipe#4233)
@TobiGr TobiGr merged commit adcc420 into TeamNewPipe:dev Sep 24, 2020
@B0pol B0pol deleted the duplicate branch November 8, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate strings Make "LeakCanary" string untranslatable
2 participants