Update Invidious URL list in the manifest #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure we should include all of them in the manifest? It will slow down the global share menu for the users installing NewPipe on their phones, and I guess many of those instances are not popular |
|
This is reducing the number of instances by two, so I'm sure it won't make it slower than it currently is, but probably a tiny bit faster. |
|
Oh, then ok, this can be merged right after 0.20.3 |
As for this, maybe once we're able to figure out how that PeerTube app is accepting share intents without putting URLs in the manifest, we could use that? |
|
@opusforlife2 yes |
TobiGr
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
Relies on the following changes
Due diligence