Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error caused by auto merging #5186

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented Dec 15, 2020

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

#5176 changed homeDir from type String to File. #5059 was based on homeDir being a String. It was incorrectly auto-resolved by git.

@TobiGr @Stypox

@XiangRongLin XiangRongLin marked this pull request as draft December 15, 2020 19:26
TeamNewPipe#5176 changed `homeDir` from type `String` to `File`. TeamNewPipe#5059 was based on `homeDir` being a `String`. It was incorrectly auto-resolved by git.
@XiangRongLin XiangRongLin marked this pull request as ready for review December 15, 2020 19:27
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TobiGr TobiGr merged commit 13e7d2e into TeamNewPipe:dev Dec 15, 2020
This was referenced Dec 21, 2020
@XiangRongLin XiangRongLin deleted the fix_compile_error branch January 16, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants