Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages for SoundCloud and YouTube unavailable contents #5385

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Better error messages for SoundCloud and YouTube unavailable contents #5385

merged 1 commit into from
Mar 7, 2021

Conversation

AudricV
Copy link
Member

@AudricV AudricV commented Jan 10, 2021 •
edited
Loading

What is it?

  • Feature (user facing)

Description of the changes in your PR

This PR add new error messages (strings added in English and French), on SoundCloud and YouTube services, when a user tries to play:

  • a SoundCloud Go+ track
  • a SoundCloud track which is blocked in his/her/its country
  • a YouTube Music Premium video
  • a YouTube paid video (a YouTube movie or a YouTube video which requires a subscription to the video channel)
  • a YouTube video which is blocked in his/her/its country (doesn't work for YouTube Music georestricted tracks because of the error message returned by YouTube)
  • a YouTube age-restricted video which could not be played, due to YouTube changes for age-restricted videos

Screenshots of the error messages

Screenshot of the error message Content type of error message
Georestricted content Georestricted content
Private content Private content
Paid content Paid content
YouTube Music Premium video YouTube Music Premium video

Fixes the following issue(s)

#4979 for SoundCloud and YouTube

Relies on the following changes

TeamNewPipe/NewPipeExtractor#509

APK testing

app.zip (from CI)

Due diligence

@XiangRongLin XiangRongLin added the feature request Issue is related to a feature in the app label Jan 14, 2021
@Stypox
Copy link
Member

Stypox commented Jan 16, 2021

Your approach is the right one. Remember to mark this as Ready when you are finished ;-)

@AudricV
Copy link
Member Author

AudricV commented Jan 16, 2021

@Stypox The implementation on NewPipe is ready but I need help to parse HLS manifests in the extractor side.

@Stypox
Copy link
Member

Stypox commented Jan 16, 2021

@TiA4f8R is it really a good idea to add support for HLS in a PR about error messages? Also, currently NewPipe's player does not support HLS, so I don't know if your workaround would work.

@AudricV AudricV marked this pull request as ready for review January 18, 2021 17:58
@AudricV
Copy link
Member Author

AudricV commented Jan 18, 2021 •
edited
Loading

@Stypox PR is ready for review and workaround for SoundCloud HLS support has been reverted (in this PR).

Stypox
Stypox requested changes Jan 18, 2021
View reviewed changes
app/build.gradle Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@AudricV AudricV requested a review from Stypox January 20, 2021 12:08
Stypox
Stypox reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably suggested the wrong thing before sorry

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@AudricV
Copy link
Member Author

AudricV commented Jan 21, 2021 •
edited
Loading

No it's me because I kept Go+ in French

Stypox
Stypox previously approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@AudricV AudricV mentioned this pull request Feb 14, 2021
Merged
3 tasks
@AudricV AudricV changed the title Better error messages for SoundCloudGo+ tracks + SoundCloud geoblocked tracks Better error messages for SoundCloud and YouTube unavailable contents Feb 14, 2021
opusforlife2
opusforlife2 reviewed Feb 14, 2021
View reviewed changes
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@AudricV
Copy link
Member Author

AudricV commented Feb 15, 2021

@TobiGr @opusforlife2 I updated the strings based on your suggestions.
The work in NewPipe should be done, now I need to understand why my code doesn't work in the extractor side for videos which requires a paid subscription to the channel which uploaded it.

TobiGr
TobiGr reviewed Feb 19, 2021
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a minor thing to improve readability.

app/src/main/java/org/schabi/newpipe/fragments/BaseStateFragment.java Outdated Show resolved Hide resolved
app/src/main/java/org/schabi/newpipe/util/ExtractorHelper.java Outdated Show resolved Hide resolved
@rocketinventor
Copy link

Hi, I noticed that "restricted" videos (videos with potentially adult content) still don't have an error message (when using YouTube's "restricted mode").

This should be added also to help achieve the goal of helping trouble-shooting and reducing confusion when a video is unavailable.

I added a comment on the original Pull Request, but I thought that this should be addressed here also.

@AudricV AudricV added GUI Issue is related to the graphical user interface soundcloud Service, https://soundcloud.com/ youtube Service, https://www.youtube.com/ labels Mar 4, 2021
TobiGr
TobiGr previously approved these changes Mar 7, 2021
View reviewed changes
@AudricV
Add different error messages for SoundCloud and YouTube unavailable c…
37a96d0 
…ontents

Add new error strings for the six new exceptions created in the extractor and catch these exceptions. Extractor is, of course, updated with this PR.
@TobiGr TobiGr merged commit ea53b7d into TeamNewPipe:dev Mar 7, 2021
@AudricV AudricV deleted the soundcloud-error-improvements branch March 7, 2021 15:40
@Stypox Stypox mentioned this pull request Mar 7, 2021
Merged
10 tasks
This was referenced Mar 21, 2021
Merged
Closed
@ghost ghost mentioned this pull request Apr 11, 2021
Open
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 21, 2021
@TobiGr @tossj
Merge pull request TeamNewPipe/NewPipe#5385 from TiA4f8R/soundcloud-e…
1b337bb 
…rror-improvements

Better error messages for SoundCloud and YouTube unavailable contents
ShareASmile added a commit to ShareASmile/FoxPipe that referenced this pull request Jun 14, 2024
@ShareASmile @TobiGr
@Stypox @AudricV @B0pol @Isira-Seneviratne @opusforlife2 @fynngodau @dkramer95 @budde25 @triallax @FireMasterK @imericxu @vmazoyer @ergor @Alexander-- @sauravrao637 @Nickoriginal @seanzzy @litetex @XiangRongLin @wb9688 @Okan25 @HybridAU @TacoTheDank @Theta-Dev @4D17Y4 @karyogamy
Merge patches of https://github.com/ShareASmile/NewPipe-Legacy-Revo a…
16b0e2c 
…s of 15-01-2024 into pre-unified-legacy

This is a fork of TeamNewPipe/NewPipe-legacy that I have been patching for a few months now. There is no commit history as this has been a personal project up until today.

Pulled in a major chunk of related commits for NewPipe Preunified from upstream TeamNewPipe/NewPipe repository:
1. Update NewPipe extractor to fetch likes count Fix TeamNewPipe/NewPipe#10624
2. Access Background Player Queue from Main menu by HybridAU
TeamNewPipe/NewPipe#8419
3. Added Bandcamp Music Support Into NewPipeLegacy, Improve Bandcamp intent filters
TeamNewPipe/NewPipe#3741
TeamNewPipe/NewPipe#6373
TeamNewPipe/NewPipe#6456
4. Disable sending metrics to Google when using Android System WebView
TeamNewPipe/NewPipe#5337
5. Add basic resize functionality
TeamNewPipe/NewPipe#3948
6. [media.ccc.de] Add recent & live stream kiosk
TeamNewPipe/NewPipe#5251
TeamNewPipe/NewPipe#5286
[media.ccc.de] Fix service color
TeamNewPipe/NewPipe#5258
7. Ability to see Pinned Comment added by dkramer95
TeamNewPipe/NewPipe#7577
8. Clicking on Title In Background Player Should Open Video Details
TeamNewPipe/NewPipe#3808 by https://github.com/budde25
9. Added Swipe to Refresh for Channels New Videos in Subscription Feed
TeamNewPipe/NewPipe#4893
10. [peertube] implement sepia search
TeamNewPipe/NewPipe#5257
11. Allow installation on external storage by triallax in
TeamNewPipe/NewPipe#6037
12. Change UA to privacy.resistFingerprinting
TeamNewPipe/NewPipe#5649 by FireMasterK
13. Add formatting removal on paste for search TeamNewPipe/NewPipe#5912 by imericxu
14. Remember Last Selected Media Type For Downloads
TeamNewPipe/NewPipe#4038 by vmazoyer
15. Improve search suggestion experience when remote ones can't be fetched
TeamNewPipe/NewPipe#4029 by StyPox
16. Fix Download Button Not Visible After Playing Live Stream, Fix video detail controls visibility set inconsistently
Add this commit by StyPox
TeamNewPipe/NewPipe@dbb86d2 from
TeamNewPipe/NewPipe#4362
17. [Background Player] Fix very small thumbnails in Video Detail Page by TobiGR in
TeamNewPipe/NewPipe#5818
18. Add Always Expand Description In Appearance Settings
TeamNewPipe/NewPipe#2998 by B0pol
(Related) entries from search history Increased from 25 to 80 and Search Suggestions Entries from 3 to 60 commit copied from
TeamNewPipe/NewPipe#2666 thanks to ergor
20. Fixes snackbar error on disabled likes count
Fixes TeamNewPipe/NewPipe#7405 by TeamNewPipe/NewPipeExtractor#753
21. Fixed player controls not hiding after replay & Bluetooth headset button by Alexander--
TeamNewPipe/NewPipe#3547
22. update user agent in Downloader to firefox latest ESR 115 by Nickoriginal
TeamNewPipe/NewPipe#8269
23. Changed Dark Theme Colors To Darker Variant by sauravrao637
TeamNewPipe/NewPipe#6244
24. Support for PeerTube Short Links
TeamNewPipe/NewPipe#7353
25. Handle URLs for YouTube Shorts
TeamNewPipe/NewPipe#7181
26. Fix playback speed not being updated in Background Player & Fix TeamNewPipe/NewPipe#8058
Fixed Combinedly by TeamNewPipe/NewPipe#6421 by Tobius
and by seanzzy in
TeamNewPipe/NewPipe#8244
27. Added comments disabled functionallity by litetex in
TeamNewPipe/NewPipe#6483
28. [media.ccc.de] Fix service color
TeamNewPipe/NewPipe#5258
29. Ignore ContentNotSupportedException caused by Bandcamp fan pages
TeamNewPipe/NewPipeExtractor#1033
30. Crash when rotating device on unsupported channels
TeamNewPipe/NewPipe#6696
31. Correct Gigaget's license from GPLv2 to GPLv3
TeamNewPipe/NewPipe#4892
32. Add basic resize functionality [Samsung Dex Now Supported]
TeamNewPipe/NewPipe#3948
33. [Security] Update ktlint to 0.40.0
34. Fix security vulnerability update checkstyle / guava
35. Update ExoPlayer from 2.11.6 to 2.11.8
36. Update checkstyle, OkHttp, use Kotlin JDK8 by TacoTheDank added this commit
TeamNewPipe/NewPipe@79e2bb3
from TeamNewPipe/NewPipe#3909
37. Use user agent of DownloaderImpl also in ReCapthaActivity
TeamNewPipe/NewPipe#5215
38. Fix ACRA bug reports not containing stack trace, Do not init ACRA if inside its own process
TeamNewPipe/NewPipe#3982
39. Remove deprecated calls to set Sender class to ACRA
TeamNewPipe/NewPipe#3982
40.Use SubtitlesStream#getUrl instead of getURL
TeamNewPipe/NewPipe#4120
41. Remove pbj=1 parameter from YouYube urls in recaptcha activity
TeamNewPipe/NewPipe#5208
42. Set notification style in Android 11 to MediaStyle Thanks to XiangRongLin for Limted Support for preunified refer to this commit
XiangRongLin@aa55a09
43. Click on title in background player opens video details
TeamNewPipe/NewPipe#3808
44. Add 2K and 4K to the options list for default resolution
 TeamNewPipe/NewPipe#2968
45. Fix crash when opening video in local playlist tab
Fixes TeamNewPipe/NewPipe#3887
by TeamNewPipe/NewPipe#3892 by wb9688
46.  Handle ContentNotSupportedException
TeamNewPipe/NewPipe#3300
47. [YouTube] Improve download speed by Theta-dev
TeamNewPipe/NewPipe#9948
48. Disable commenter image when disabling thumbnails loading by 4D17Y4
Fixes TeamNewPipe/NewPipe#4205
TeamNewPipe/NewPipe#4350
49. Adapt opacity of popup close button to allow touches in other apps on Android >=11
Fixes TeamNewPipe/NewPipe#6770
TeamNewPipe/NewPipe#8279
50. Better error messages for SoundCloud and YouTube unavailable contents
TeamNewPipe/NewPipe#5385
51. Mitigating long buffering on initial video playback by using custom progress-load-interval in exoplayer,
Use 16 KiB as the default progressive load interval by karyogamy
TeamNewPipe/NewPipe#7919
52. Support for opening YouTube Live URLs
TeamNewPipe/NewPipe#9725

Co-Authored-By: Tobi <17365767+tobigr@users.noreply.github.com>
Co-Authored-By: Stypox <stypox@pm.me>
Co-Authored-By: Audric V. <74829229+audricv@users.noreply.github.com>
Co-Authored-By: bopol <58657617+b0pol@users.noreply.github.com>
Co-Authored-By: Isira Seneviratne <31027858+isira-seneviratne@users.noreply.github.com>
Co-Authored-By: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-Authored-By: fynngodau <fynngodau@mailbox.org>
Co-Authored-By: David Kramer <6166095+dkramer95@users.noreply.github.com>
Co-Authored-By: Ethan Budd <budde25@protonmail.com>
Co-Authored-By: triallax <triallax@tutanota.com>
Co-Authored-By: Kavin <20838718+firemasterk@users.noreply.github.com>
Co-Authored-By: Eric Xu <xeric.2002@gmail.com>
Co-Authored-By: Vincent Mazoyer <17800856+vmazoyer@users.noreply.github.com>
Co-Authored-By: Erol Gorancic <erol@gorancic.no>
Co-Authored-By: Alexander-- <1107390+alexander--@users.noreply.github.com>
Co-Authored-By: Saurav Rao <56369484+sauravrao637@users.noreply.github.com>
Co-Authored-By: Nickoriginal <85299944+nickoriginal@users.noreply.github.com>
Co-Authored-By: Ziyan Zhang <71145592+seanzzy@users.noreply.github.com>
Co-Authored-By: litetex <40789489+litetex@users.noreply.github.com>
Co-Authored-By: XiangRongLin <41164160+xiangronglin@users.noreply.github.com>
Co-Authored-By: wb9688 <46277131+wb9688@users.noreply.github.com>
Co-Authored-By: Okan25 <92695587+okan25@users.noreply.github.com>
Co-Authored-By: Michael Van Delft <1610265+hybridau@users.noreply.github.com>
Co-Authored-By: Taco <32376686+tacothedank@users.noreply.github.com>
Co-Authored-By: ThetaDev <thetadev@magenta.de>
Co-Authored-By: Aditya-Srivastav <54016427+4d17y4@users.noreply.github.com>
Co-Authored-By: John Zhen Mo <zhenmogukl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opusforlife2 opusforlife2 opusforlife2 left review comments

@TobiGr TobiGr TobiGr approved these changes

@Stypox Stypox Stypox left review comments

Assignees
No one assigned
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface soundcloud Service, https://soundcloud.com/ youtube Service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AudricV @Stypox @rocketinventor @TobiGr @opusforlife2 @XiangRongLin