Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize timestamps and hashtags in descriptions and do some sharing fixes and improvements #5523

Merged
merged 20 commits into from
Jun 15, 2021
Merged

Commits on Jun 11, 2021

  1. Open recognized timestamps in the description of contents in the popu…

    …p player
    
    This commit adds support of opening recognized timestamps in the popup
    player instead of starting an intent which opens the YouTube website with
    the video timestamp.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    4031777 View commit details
    Browse the repository at this point in the history
  2. Initial work: add support for opening timestamps in plain text descri…

    …ptions
    
    This commit adds support for opening plain text timestamps by parsing the description text using a regular expression, add a click listener for each timestamp which opens the popup player at the indicated time in the timestamp.
    In order to do this, playOnPopup method of the URLHandler class. Also, handleUrl method of this class has been renamed to canHandleUrl.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    ae9349e View commit details
    Browse the repository at this point in the history
  3. Fix toast shown when falling back to Google Play Store URL and the ac…

    …tion of Open with Kodi button in the player
    
    Add a boolean param, showToast, in ShareUtils.openIntentInApp and only show toast "No app on your device can open this" if this boolean is true.
    Fix the action of play with Kodi button by applying the fix provided in #5599 (adding the flag Intent.FLAG_ACTIVITY_NEW_TASK to the intent in NavigationHelper.playWithKore method).
    Do also some cleanup in viewWithFileProvider and shareFile methods of MissionAdapter class.
    AudricV committed Jun 11, 2021
    1 Configuration menu
    Copy the full SHA
    9e9d1a0 View commit details
    Browse the repository at this point in the history
  4. Try to change message of the system chooser for the update notification

    This commit tries to change the title of the system chooser shown, which is from Android System ("Open links with"), when no defaut browser is present, for the update notification.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    6abdd2a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c972940 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2fb8636 View commit details
    Browse the repository at this point in the history
  7. Initial work to add the image of the content in the share sheet

    Also do some fixes when sharing a file in downloads and some improvements in JavaDocs of ShareUtils class.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    d85afd6 View commit details
    Browse the repository at this point in the history
  8. Move some classes to a new subpackage and adress requested changes

    Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
    Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
    Remove unused param showPreviewText in shareText method of ShareUtils class.
    Add initial work to be able to display an image preview of the content shared (not for downloads).
    Use a better regular expression to parse timestamps in plain text descriptions.
    AudricV committed Jun 11, 2021
    1 Configuration menu
    Copy the full SHA
    d6decc0 View commit details
    Browse the repository at this point in the history
  9. Move some classes to a new subpackage and adress requested changes

    Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
    Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
    Remove unused param showPreviewText in shareText method of ShareUtils class.
    Add initial work to be able to display an image preview of the content shared (not for downloads).
    Use a better regular expression to parse timestamps in plain text descriptions.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    e5df2f6 View commit details
    Browse the repository at this point in the history
  10. Initial work: add support for opening hashtags in plain text descript…

    …ions
    
    This commit adds supports for opening hashtags in plain text descriptions, using the same logic as timestamps.
    Every hashtag opens a search on the current service with the text in the hashtag.
    Also use a better regular expression for parsing timestamps.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    267686f View commit details
    Browse the repository at this point in the history
  11. Don't use a chooser for other intents than opening a content in a bro…

    …wser or sharing a content to other apps
    
    Use an ACTION_CHOOSER intent has a negative impact for user experience, because user cannot set as default an activity for an intent
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    2702700 View commit details
    Browse the repository at this point in the history
  12. Adress requested changes and try some cleanup in handleUrl method of …

    …InternalUrlsHandler class
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    a79badd View commit details
    Browse the repository at this point in the history
  13. Split handleUrl method into two methods

    Split handleURL method, now private, into two methods:
    handleUrlCommentsTimestamp and handleUrlDescriptionTimestamp. Code is
    now more proper.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    f13f4cc View commit details
    Browse the repository at this point in the history
  14. Initial work: use disposables for timestamps parsing in YouTube video…

    … descriptions and YouTube comments
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    da4d379 View commit details
    Browse the repository at this point in the history
  15. Fix an error and add a new method in the ShareUtils class

    Fix the error due to the rebase on the dev branch of this branch
    Add a shareText method in the ShareUtils class which has 3 parameters and calls
    the original shareText method with an empty string for the
    imagePreviewUrl param.
    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    f02df6d View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    218f25c View commit details
    Browse the repository at this point in the history
  17. Improve text linkifier function parameters

    Stypox authored and AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    eef418a View commit details
    Browse the repository at this point in the history
  18. Fix disposables handling for text linkifier

    also use differently Markwon methods to convert plain text to markdown
    Stypox authored and AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    edfe0f9 View commit details
    Browse the repository at this point in the history
  19. Fix the compile error

    AudricV committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    32b0bdb View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    4eef498 View commit details
    Browse the repository at this point in the history