-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize timestamps and hashtags in descriptions and do some sharing fixes and improvements #5523
Commits on Jun 11, 2021
-
Open recognized timestamps in the description of contents in the popu…
…p player This commit adds support of opening recognized timestamps in the popup player instead of starting an intent which opens the YouTube website with the video timestamp.
Configuration menu - View commit details
-
Copy full SHA for 4031777 - Browse repository at this point
Copy the full SHA 4031777View commit details -
Initial work: add support for opening timestamps in plain text descri…
…ptions This commit adds support for opening plain text timestamps by parsing the description text using a regular expression, add a click listener for each timestamp which opens the popup player at the indicated time in the timestamp. In order to do this, playOnPopup method of the URLHandler class. Also, handleUrl method of this class has been renamed to canHandleUrl.
Configuration menu - View commit details
-
Copy full SHA for ae9349e - Browse repository at this point
Copy the full SHA ae9349eView commit details -
Fix toast shown when falling back to Google Play Store URL and the ac…
…tion of Open with Kodi button in the player Add a boolean param, showToast, in ShareUtils.openIntentInApp and only show toast "No app on your device can open this" if this boolean is true. Fix the action of play with Kodi button by applying the fix provided in #5599 (adding the flag Intent.FLAG_ACTIVITY_NEW_TASK to the intent in NavigationHelper.playWithKore method). Do also some cleanup in viewWithFileProvider and shareFile methods of MissionAdapter class.
1Configuration menu - View commit details
-
Copy full SHA for 9e9d1a0 - Browse repository at this point
Copy the full SHA 9e9d1a0View commit details -
Try to change message of the system chooser for the update notification
This commit tries to change the title of the system chooser shown, which is from Android System ("Open links with"), when no defaut browser is present, for the update notification.
Configuration menu - View commit details
-
Copy full SHA for 6abdd2a - Browse repository at this point
Copy the full SHA 6abdd2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c972940 - Browse repository at this point
Copy the full SHA c972940View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fb8636 - Browse repository at this point
Copy the full SHA 2fb8636View commit details -
Initial work to add the image of the content in the share sheet
Also do some fixes when sharing a file in downloads and some improvements in JavaDocs of ShareUtils class.
Configuration menu - View commit details
-
Copy full SHA for d85afd6 - Browse repository at this point
Copy the full SHA d85afd6View commit details -
Move some classes to a new subpackage and adress requested changes
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils. Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage. Remove unused param showPreviewText in shareText method of ShareUtils class. Add initial work to be able to display an image preview of the content shared (not for downloads). Use a better regular expression to parse timestamps in plain text descriptions.
1Configuration menu - View commit details
-
Copy full SHA for d6decc0 - Browse repository at this point
Copy the full SHA d6decc0View commit details -
Move some classes to a new subpackage and adress requested changes
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils. Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage. Remove unused param showPreviewText in shareText method of ShareUtils class. Add initial work to be able to display an image preview of the content shared (not for downloads). Use a better regular expression to parse timestamps in plain text descriptions.
Configuration menu - View commit details
-
Copy full SHA for e5df2f6 - Browse repository at this point
Copy the full SHA e5df2f6View commit details -
Initial work: add support for opening hashtags in plain text descript…
…ions This commit adds supports for opening hashtags in plain text descriptions, using the same logic as timestamps. Every hashtag opens a search on the current service with the text in the hashtag. Also use a better regular expression for parsing timestamps.
Configuration menu - View commit details
-
Copy full SHA for 267686f - Browse repository at this point
Copy the full SHA 267686fView commit details -
Don't use a chooser for other intents than opening a content in a bro…
…wser or sharing a content to other apps Use an ACTION_CHOOSER intent has a negative impact for user experience, because user cannot set as default an activity for an intent
Configuration menu - View commit details
-
Copy full SHA for 2702700 - Browse repository at this point
Copy the full SHA 2702700View commit details -
Adress requested changes and try some cleanup in handleUrl method of …
…InternalUrlsHandler class
Configuration menu - View commit details
-
Copy full SHA for a79badd - Browse repository at this point
Copy the full SHA a79baddView commit details -
Split handleUrl method into two methods
Split handleURL method, now private, into two methods: handleUrlCommentsTimestamp and handleUrlDescriptionTimestamp. Code is now more proper.
Configuration menu - View commit details
-
Copy full SHA for f13f4cc - Browse repository at this point
Copy the full SHA f13f4ccView commit details -
Initial work: use disposables for timestamps parsing in YouTube video…
… descriptions and YouTube comments
Configuration menu - View commit details
-
Copy full SHA for da4d379 - Browse repository at this point
Copy the full SHA da4d379View commit details -
Fix an error and add a new method in the ShareUtils class
Fix the error due to the rebase on the dev branch of this branch Add a shareText method in the ShareUtils class which has 3 parameters and calls the original shareText method with an empty string for the imagePreviewUrl param.
Configuration menu - View commit details
-
Copy full SHA for f02df6d - Browse repository at this point
Copy the full SHA f02df6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 218f25c - Browse repository at this point
Copy the full SHA 218f25cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eef418a - Browse repository at this point
Copy the full SHA eef418aView commit details -
Fix disposables handling for text linkifier
also use differently Markwon methods to convert plain text to markdown
Configuration menu - View commit details
-
Copy full SHA for edfe0f9 - Browse repository at this point
Copy the full SHA edfe0f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32b0bdb - Browse repository at this point
Copy the full SHA 32b0bdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4eef498 - Browse repository at this point
Copy the full SHA 4eef498View commit details