Better error handling of terminated channels

[TobiGr]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• give a reason, why a feed could not be loaded when possible
• allow to unsubscribe from the dedicated channel
• show that an account has been terminated and (if provided) the reason for the termination in ChannelFragment

ToDo

• display the information in the channel fragment
• loading state is not changed correctly for some reason.

Fixes the following issue(s)

• Fixes Deleted Channels Throw An Error When Refreshing Subscription Feed #3313
• Closes Feed fetching errors has bad UI/UX #5452

Relies on the following changes

• Add AccountTerminatedException for terminated channels NewPipeExtractor#580

Screenshots

Screenshots

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

I manipulated the subscription export to contain only URls to termianted or not available channels. Extract the json and import it for testing:
newpipe_termianted.json.zip

Due diligence

• I read the contribution guidelines.

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[opusforlife2]

Sorely needed!

But... how do you test? xD

[triallax]

Two minor things. I guess the files should probably be formatted too.

[TobiGr]

But... how do you test? xD

@opusforlife2 I added a manipulated subscription export to the PR description

@Stypox Can you help me with the feed loading UI? I am unable to solve that at the moment. Just install the APK, import the subscriptions, refresh the feed and hit unsubscribe or cancel on error to see the problem.

[Stypox]

I am not sure I understand what I should test. When importing the subscriptions you provided nothing happens (i.e. no subscriptions are added). I tried both importing the json from the subscription fragment and importing the zip from content settings

[TobiGr]

@Stypox Did you extract the json from the ZIP file before importing it via the subscription import dialog?

Anyway, here's a screen cast of the problem. As you can see, the feed keeps loading forever, although loading the items is completed.

device-2021-04-01-152332.mp4

[Stypox]

@TobiGr I tried to understand how the feed loading works but I have failed so far, will try again tomorrow.

[Stypox]

@TobiGr @opusforlife2 what do you think of this implementation? It now shows correctly the loaded feed and shows a dialog for each invalid subscription. If something unrelated to channel being terminated goes wrong (e.g. a network error), the bar at the top correctly shows the number of channels that could not be loaded, instead of showing "Network error". Here is a settings export (--> import it from settings): NewPipeData-20210402_120407.zip

[TobiGr]

Thank you. Looks good!

I fixed two small bugs (see commit message)

[TobiGr]

NewPipeData-20210402_120407.zip
The Pokemon channel is terminated now.

[opusforlife2]

Sorry, this slipped my mind yesterday. From the Subscriptions tab, I can see the 2 kinds of errors you pointed out: content unavailable, and channel terminated.

Refreshing a feed with the terminated Pokemon channel shows "channel terminated, wanna unsub?" so it's fine.

Doing the same with the content unavailable channel shows "got error: channel does not exist." No idea if the message is correct here. "Content unavailable" and "channel does not exist" seem like two different things.

Now the bugs:

• If you put both the terminated and content unavailable channels in a channel group and refresh the feed, or try refreshing the What's New feed, you get one of the two dialogs, randomly selected. If you unsubscribe from one, you are shown the other as well. But if you tap cancel or tap outside the dialog box to dismiss it, you are not shown the second exception. It should show both each time.
• Once you get either exception, cancel and go back to the Subscriptions tab. You will encounter the last shown exception as you back out of the channel group. Now keep opening one of the two valid channels and tapping Back. You keep getting the last stored exception every time you return to the Subscriptions tab upon tapping Back.
• But if you do the same thing after unsubscribing from at least one or both channels, you don't get an exception with the same steps.

[TobiGr]

Rebased

[Stypox]

LGTM, thank you :-)

Done

[opusforlife2]

Did you fix the bugs I found?