Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for screenshots/video of UI changes in PR template #6539

Merged
merged 2 commits into from
Jun 24, 2021
Merged

Ask for screenshots/video of UI changes in PR template #6539

merged 2 commits into from
Jun 24, 2021

Conversation

opusforlife2
Copy link
Collaborator

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Added a screenshots/screen record section to the PR template to encourage PR authors who make UI changes to provide visual feedback of what exactly changed with their PR.

Due diligence

@opusforlife2
Ask for screenshots/video of UI changes
a9e85ab 
If the PR author has changed the UI of the app, they should include screenshots or a video so that developers and users alike can pinpoint exactly what changed.
@opusforlife2 opusforlife2 requested a review from B0pol June 20, 2021 21:19
@XiangRongLin XiangRongLin added the meta Related to the project but not strictly to code label Jun 21, 2021
B0pol
B0pol requested changes Jun 21, 2021
View reviewed changes
Copy link
Member

@B0pol B0pol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add something like delete this if you did not change UI.

I would also put that section right after Description, before fixes issues / relies on PR…

@opusforlife2
Address Bopol's review
090c063 
Changed the location, added option to delete, and also fixed a tiny grammar thingy.
@opusforlife2 opusforlife2 requested a review from B0pol June 24, 2021 15:16
@B0pol B0pol merged commit c398308 into dev Jun 24, 2021
@opusforlife2 opusforlife2 deleted the screenshots_for_UI_changes branch June 24, 2021 15:49
This was referenced Jun 26, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B0pol B0pol B0pol approved these changes

Assignees
No one assigned
Labels
meta Related to the project but not strictly to code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opusforlife2 @B0pol @XiangRongLin