Properly support other delivery methods #367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is anyone able to review this? |
Stypox
requested changes
Aug 5, 2020
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Outdated
Show resolved
Hide resolved
...in/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java
Show resolved
Hide resolved
The code mostly comes from #358 Co-Authored-By: Mauricio Colli <mauriciocolli@outlook.com>
|
@Stypox: Could you review this again? This PR shouldn't be merged yet though, as I haven't properly tested e.g. whether the YouTube DASH extraction is actually correct (the output looks correct though). Btw I just started working on the NewPipe part of this. |
Stypox
requested changes
Sep 3, 2020
| if (fmt != null && languageCode != null) | ||
| subtitles.add(new SubtitlesStream(fmt, languageCode, url, false)); | ||
| if (fmt != null && languageCode != null) { | ||
| final String id = languageCode + "." + fmt.suffix; |
There was a problem hiding this comment.
Make a constructor of SubtitlesStream without id, so that it can be automatically set to this. I see this is being used also in YoutubeStreamExtractor
| } else if (t.getString("preset").contains("opus")) { | ||
| mediaFormat = MediaFormat.OPUS; | ||
| } else { | ||
| break; |
There was a problem hiding this comment.
Why break and not continue? Also below.
34 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatible with the changed API.
Changes
DeliveryFormatenumurlinStreamtocontentand addisUrlto indicate whethercontentcontains the URL or the file itself (which is useful when we have to split DASH/HLS manifests)idinStreamto identify a specific stream (there could be multipleStreams with the same ID if the same stream is offered through multiple delivery methods; in YouTube's case the ID would be the itag)When all changes are finished, I'm going to work on implementing them in NewPipe's downloader. When I'm done with that and the unified player has been merged, I'll look at implementing it in the player as well.
I'll leave not hardcoding itags to another PR.