Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SubtitlesStream#getURL() #386

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Remove SubtitlesStream#getURL() #386

merged 2 commits into from
Aug 26, 2020

Conversation

triallax
Copy link
Contributor

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Fixes #350.

wb9688
wb9688 requested changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@wb9688 wb9688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also remove the redundant url field from this class

@triallax triallax mentioned this pull request Aug 12, 2020
Merged
5 tasks
@triallax
Copy link
Contributor Author

Will do!

@triallax
Copy link
Contributor Author

Done!

@TobiGr
Copy link
Member

TobiGr commented Aug 12, 2020 •
edited
Loading

Just a little off-topic question: why are the class variables public in Stream?
@wb9688 Any idea? I didn't find any reason for this behaviour by searching for usages in IntelliJ.

@TobiGr TobiGr merged commit 6633f26 into TeamNewPipe:dev Aug 26, 2020
@triallax triallax deleted the remove-subtitles-stream-get-url branch August 28, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wb9688 wb9688 wb9688 requested changes

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SubtitlesStream#getURL()
3 participants
@triallax @TobiGr @wb9688