[YouTube]: Fixed channel continuation #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B0pol
changed the title
B0pol
added
bug
5 tasks
TobiGr
reviewed
Feb 12, 2021
| @@ -252,36 +250,47 @@ public String getParentChannelAvatarUrl() throws ParsingException { | |||
| final JsonArray ajaxJson = getJsonResponse(page.getUrl(), getExtractorLocalization()); | |||
|
|
|||
| JsonObject sectionListContinuation = ajaxJson.getObject(1).getObject("response") | |||
| .getObject("continuationContents").getObject("gridContinuation"); | |||
| .getArray("onResponseReceivedActions").getObject(0).getObject("appendContinuationItemsAction"); | |||
There was a problem hiding this comment.
is it safe to assume that the appendContinuationItemsAction object is always in the first array element?
There was a problem hiding this comment.
youtube-dl also assume it's the first element. https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/extractor/youtube.py#L2507
but if you wanna be sure the safest way is a simple for loop.
TobiGr
approved these changes
Feb 12, 2021
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes TeamNewPipe/NewPipe#5550