Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkstyle #817

Merged
merged 23 commits into from
Mar 26, 2022
Merged

Add checkstyle #817

merged 23 commits into from
Mar 26, 2022

Commits on Mar 26, 2022

  1. Add checkstyle to extractor gradle project 

    With respect to NewPipe's checkstyle.xml, checkstyle is disabled for javadoc comments. There is no need for strict rules over comments here in the extractor, as sometimes javadocs are just needed to clarify a small thing and having empty/meaningless @param or @throws is useless.
    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    3769005 View commit details
    Browse the repository at this point in the history

  2. Refactor code handling http headers in downloader.Request

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    e4951a0 View commit details
    Browse the repository at this point in the history

  3. Fix checkstyle issues in subpackages with abstract classes

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    8aba2b4 View commit details
    Browse the repository at this point in the history

  4. Fix checkstyle issues & more in DashMpdParser 

    Also remove useless null check on ItagItem.getItag() as that function already throws an exception if there is no itag
    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    bd7b362 View commit details
    Browse the repository at this point in the history

  5. Fix checkstyle issues & more in DonationLinkHelper 

    Also add comment about the class being unused and replace the fixLink function with Utils.stringToUrl()
    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    87d2834 View commit details
    Browse the repository at this point in the history

  6. Fix checkstyle issues & more in JsonUtils 

    Also use Java 8 streams and extract duplicate code to getInstanceOf function
    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    1d5f22e View commit details
    Browse the repository at this point in the history

  7. Fix remaining checkstyle issues in utils/ subpackage

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    ca7c63f View commit details
    Browse the repository at this point in the history

  8. Fix checkstyle issues in root package extractor/ 

    Note: not all issues were fixed because MediaFormat and ServiceList use a specific formatting that makes sense for them
    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    d79e203 View commit details
    Browse the repository at this point in the history

  9. Use Java 8 streams and deduplicate code in MediaFormat class

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    c2446ec View commit details
    Browse the repository at this point in the history

  10. Use Java 8 streams in NewPipe class

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    08dff33 View commit details
    Browse the repository at this point in the history

  11. [Bandcamp] Fix checkstyle issues

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    3a94839 View commit details
    Browse the repository at this point in the history

  12. [MediaCCC] Fix checkstyle issues

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    9f7e06c View commit details
    Browse the repository at this point in the history

  13. [Peertube] Fix checkstyle issues

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    9ab32cb View commit details
    Browse the repository at this point in the history

  14. [Soundcloud] Fix checkstyle issues

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    9dc17cd View commit details
    Browse the repository at this point in the history

  15. [YouTube] Fix checkstyle issues

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    740a37a View commit details
    Browse the repository at this point in the history

  16. Legitimately suppress remaining checkstyle warnings

    @Stypox @litetex
    Stypox authored and litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    bdadcfa View commit details
    Browse the repository at this point in the history

  17. Fixed typo

    @litetex
    litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    01cfde0 View commit details
    Browse the repository at this point in the history

  18. Restored original naming

    @litetex
    litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    8771af7 View commit details
    Browse the repository at this point in the history

  19. Removed unused class

    @litetex
    litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    ec5b54c View commit details
    Browse the repository at this point in the history

  20. Removed unused methods 

    ``contentFilters`` and ``sortfilter`` are get inside the ``ListLinkHandler`` and not the ``ListLinkHandlerFactory``
 ``ListLinkHandlerFactory`` only passes these values through when ``fromQuery`` is called
    @litetex
    litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    33347ac View commit details
    Browse the repository at this point in the history

  21. Fixed new checkstyle problems from dev

    @litetex
    litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    804e570 View commit details
    Browse the repository at this point in the history

  22. CI: Upload test reports when failure occurs

    @litetex
    litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    93d6e5c View commit details
    Browse the repository at this point in the history

  23. Fix useage of wrong object

    @litetex
    litetex committed Mar 26, 2022
    Configuration menu
    Copy the full SHA
    9c07e8a View commit details
    Browse the repository at this point in the history