Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[init] Amplitude 기초 세팅 #219

Merged
merged 6 commits into from
Mar 4, 2024
Merged

[init] Amplitude 기초 세팅 #219

merged 6 commits into from
Mar 4, 2024

Conversation

jihyunniiii
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • Amplitude 기초 세팅 완료하였습니다.

Screenshot 📸

스크린샷 2024-03-04 오후 3 48 11

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

  • 테스트 트래킹 이벤트 보내서 기초세팅 잘 된 거 확인했습니다. 근데 기획 측에서 추가적으로 해야할 작업이 아직 남아 있어서 아마 바로 확인은 안 될 것 같습니당 ㅠ 완료 되면 확인하는 법 알려드릴게용 ~
  • local.properties 업데이트 필요합니다! 슬랙에 공유드릴게요.
  • AmplitudeUtils 만들어 두었습니다. (trackEvent -> 매개변수 없는 이벤트, trackEventWithProperty -> 매개변수 한 개인 이벤트, trackEventWithProperties -> 매개변수 여러 개인 이벤트 에 사용해주시면 됩니다.)
  • 추가적으로 3차 스프린트 Amplitude 마일스톤 만들어 두었으니 Amplitude 관련 이슈 및 PR은 해당 마일스톤으로 설정해주시면 됩니다.

@jihyunniiii jihyunniiii self-assigned this Mar 4, 2024
@jihyunniiii jihyunniiii requested a review from a team as a code owner March 4, 2024 06:57
Dan2dani
Dan2dani approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@Dan2dani Dan2dani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다ㅣ

HAJIEUN02
HAJIEUN02 reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@HAJIEUN02 HAJIEUN02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

짱이다!

.github/workflows/pr_builder.yml
@@ -47,11 +47,6 @@ jobs:
HFM_BASE_URL: ${{ secrets.BASE_URL }}
run: echo "base.url=\"$BASE_URL\"" >> local.properties

- name: Access ACCESS_TOKEN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오잉 이건 왜 지우는 거에요??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

액세스 토큰 이제 로컬에 저장할 필요 없어서용

@jihyunniiii jihyunniiii merged commit a558a13 into develop Mar 4, 2024
1 check passed
@jihyunniiii jihyunniiii deleted the init-amplitude branch March 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HAJIEUN02 HAJIEUN02 HAJIEUN02 left review comments

@Dan2dani Dan2dani Dan2dani approved these changes

Assignees

@jihyunniiii jihyunniiii

Labels
⚡️ init ⚡️ 🐸 지현 🐸
Projects
PINGLE-ANDROID
Status: Done
Milestone
3차 스프린트 Amplitude
Development

Successfully merging this pull request may close these issues.

[init] Amplitude 기초 세팅
3 participants
@jihyunniiii @Dan2dani @HAJIEUN02