-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] 3차 스프린트 QA 수정사항 반영 #245
Merged
Merged
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
eae8e5d
[chore] #243 랭킹 아이템 숫자 크기 12Bold -> 16Bold
jihyunniiii a38eca9
[chore] #243 랭킹 데이터 텍소노미 스크롤 시작 시점으로 변경
jihyunniiii 1ed2ef1
[chore] #243 PingleSearch -> EditText가 비었을 시 검색 버튼 비활성화
jihyunniiii f35c0b3
[chore] #243 지도/리스트 뷰 -> 검색창에서 뒤로가기 클릭 시 검색 취소 + 검색페이지로 이동
jihyunniiii a9446a1
[fix] #244 나의 단체 뷰 : 단체 변경시 모달에서 단체명 13자 이상일 시에 12자까지만 노출시키고 ‘…’처리
HAJIEUN02 c4dbae0
[chore] #244 나의 단체 뷰 : const val -> private const val로 수정
HAJIEUN02 78640d9
[fix] #244 온보딩 추가설명 뷰 : 0개 단체 가입된 사용자 앱 재실행 시 온보딩 추가설명 뷰 입장 방식 선택 뷰가 …
HAJIEUN02 4ba3b9c
[chore] #243 ktlintFormat
jihyunniiii e9fdc83
Merge branch 'develop' into fix-3rd-sprint-qa-jihyun
jihyunniiii 2aebbd7
[chore] #243 makeEllipsisGroupName when 문으로 수정
jihyunniiii 0f0c84e
[chore] #243 PingleLocalDataSource에 sharedPreference 추가
jihyunniiii 1775e47
[chore] #243 단체 변경 후 홈 화면 진입 시 검색 결과가 유지되어 있는 문제 해결 (OnSharedPreferen…
jihyunniiii 0b48ceb
[chore] #243 검색 + 지도 뷰에서 칩 필터링을 진행하는 경우 검색 결과가 없어도 지도뷰 유지
jihyunniiii 011a9b6
[feat] #243 홈 뷰 핑글 정보 조회를 위한 정보를 하나로 관리하기 위한 모델 생성
jihyunniiii 54f60c0
[feat] #243 홈 뷰 핑글 정보 조회를 위한 정보 (카테고리, 검색어, HomeViewType, Order) 하나의 …
jihyunniiii 041e09a
[chore] #243 ktlintFormat
jihyunniiii ca2b255
Merge remote-tracking branch 'origin/fix-3rd-sprint-qa-jihyun' into f…
HAJIEUN02 5dbf5e8
Merge branch 'develop' into fix-3rd-sprint-qa-jihyun
HAJIEUN02 8c87a8a
Merge branch 'develop' into fix-3rd-sprint-qa-jihyun
jihyunniiii 6471797
[chore] #243 로그아웃/탈퇴 후 이동 화면 수정 (Onboarding)
jihyunniiii 4e27cbf
[chore] #243 Log 삭제
jihyunniiii 1d28f7b
[chore] #243 오타 수정
jihyunniiii 22a28bc
[chore] #243 로그아웃/탈퇴 후 이동 액티비티 수정 (auth)
jihyunniiii 751d77f
[chore] #243 ktlintFormat
jihyunniiii 2cf81e5
Merge remote-tracking branch 'origin/fix-3rd-sprint-qa-jihyun' into f…
HAJIEUN02 b95ce26
[fix] #243 로그아웃/탈퇴 후 온보딩, 최초 접속 시 온보딩 뒤로가기 버튼 로직 분리
HAJIEUN02 993395f
[chore] #243 ktlintFormat
HAJIEUN02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -98,10 +98,11 @@ class MyGroupActivity : BindingActivity<ActivityMyGroupBinding>(R.layout.activit | |
private fun showChangeGroupModal(clickedEntity: MyGroupEntity) { | ||
AmplitudeUtils.trackEvent(CLICK_OTHERGROUP) | ||
binding.layoutMyGroupSelectedMenu.visibility = View.INVISIBLE | ||
|
||
MyGroupModalDialogFragment( | ||
title = getString( | ||
R.string.my_group_modal_move_question, | ||
clickedEntity.name | ||
makeEllipsisGroupName(clickedEntity.name) | ||
), | ||
buttonText = stringOf(R.string.my_group_modal_change), | ||
textButtonText = stringOf(R.string.my_group_modal_back), | ||
|
@@ -142,15 +143,27 @@ class MyGroupActivity : BindingActivity<ActivityMyGroupBinding>(R.layout.activit | |
} | ||
} | ||
|
||
private fun makeEllipsisGroupName(groupName: String): String { | ||
return if (groupName.length > GROUP_NAME_MAX_LENGTH) { | ||
"${groupName.substring(SUBSTRING_START_INDEX, SUBSTRING_END_INDEX) + ELLIPSIS}" | ||
} else { | ||
groupName | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기 {} 없이 한줄로 깔끔하게 고고!? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @DoReMinWoo 제가 커밋한 부분이네욥 ㅋ.ㅋ 지현언니가 수정해준대요... |
||
} | ||
|
||
companion object { | ||
private const val CHANGE_MODAL = "ChangeGroupModal" | ||
private const val SNACKBAR_BOTTOM_MARGIN = 57 | ||
|
||
const val CLICK_INVITECODE = "click_invitecode" | ||
const val CLICK_INVITECODE_COPY = "click_invitecode_copy" | ||
const val CLICK_INVITECODE_SHARE = "click_invitecode_share" | ||
const val CLICK_OTHERGROUP = "click_othergroup" | ||
const val CLICK_OTHERGROUP_CHANGE = "click_othergroup_change" | ||
const val CLICK_NEWGROUP = "click_newgroup" | ||
private const val SUBSTRING_START_INDEX = 0 | ||
private const val SUBSTRING_END_INDEX = 12 | ||
private const val GROUP_NAME_MAX_LENGTH = 13 | ||
private const val ELLIPSIS = "..." | ||
|
||
private const val CLICK_INVITECODE = "click_invitecode" | ||
private const val CLICK_INVITECODE_COPY = "click_invitecode_copy" | ||
private const val CLICK_INVITECODE_SHARE = "click_invitecode_share" | ||
private const val CLICK_OTHERGROUP = "click_othergroup" | ||
private const val CLICK_OTHERGROUP_CHANGE = "click_othergroup_change" | ||
private const val CLICK_NEWGROUP = "click_newgroup" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분 진짜 확장함수 쓰기 은근 어렵지 않나여?,, ㅜ.ㅜ 확장함수 그거 하나로 다 해결하고 싶은데 도저히 어떻게 해야할지 머르겠네요.. 온보딩 추가설명 뷰에서도 결국엔 실패했는데
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아니 그니까용,,, 뒤로가기 버튼 관리 쉽지 않타,,, 이거 이번 스프린트 끝나고 어떻게 하면 잘 관리할 수 있을지 고민해 봐야겠서염 ㅠ