[fix] 3차 스프린트 QA 수정사항 반영 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
[신규 단체 개설] 단체명 중복 검사 후 안내 페이지 갔다가 다시 오면 중복확인 풀려있음 Screen_recording_20240312_082021.mp4 |
jihyunniiii
reviewed
Mar 11, 2024
Comment on lines
64
to
66
| viewModel.joinGroupCodeEditText.observe(this) { editText -> | ||
| viewModel.joinGroupCodeEditText.flowWithLifecycle(lifecycle).onEach { editText -> | ||
| binding.btnJoinGroupCodeNext.isEnabled = editText.isNotEmpty() | ||
| } | ||
| }.launchIn(lifecycleScope) |
There was a problem hiding this comment.
어머어머 제가 바꿔놓고 까먹었네요 키키
There was a problem hiding this comment.
중복확인 후 안내 페이지 띄웠을 때 중복확인 버튼이 비활성화 안 되어 있는 문제
-> onResume에 btnEditTextCheck.isEnabled 값 세팅해주기
Comment on lines
33
to
41
| if (newGroupViewModel.newGroupKeywordValue.value.isNotEmpty()) { | ||
| for (i in 0 until binding.cgNewGroupKeyword.childCount) { | ||
| val childChip = binding.cgNewGroupKeyword.getChildAt(i) as Chip | ||
| if (childChip.text == newGroupViewModel.newGroupKeywordValue.value) { | ||
| childChip.isChecked = true | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
with(newGroupViewModel.newGroupKeywordValue.value) {
if (isNotEmpty()) {
binding.cgNewGroupKeyword.forEach { childChip ->
(childChip as Chip).let { chip ->
if (chip.text == this) chip.isChecked = true
}
}
}
}
스코프 함수를 활용해 이렇게 변경할 수도 있을 것 같습니둥
There was a problem hiding this comment.
오홍 이래서 코틀린 문법을 공부해야하는군여....
3번까지 다 되면 머지 ㄱㄱ 해도 될 것 같아요. |
HAJIEUN02
approved these changes
Mar 12, 2024
| SNACKBAR_BOTTOM_MARGIN, | ||
| SnackbarType.WARNING | ||
| newGroupViewModel.newGroupCheckNameState.flowWithLifecycle(lifecycle) | ||
| .distinctUntilChanged() |
There was a problem hiding this comment.
여기서도 distinctUntilChange를 안 쓰면 안 되는 문제가 생겼었나 보네요,, 무슨 문제였나요??
There was a problem hiding this comment.
이거 지도뷰랑 같은 문제염 ㅜㅜ 위에 액티비티 떴다가 사라지면 값이 같은데도 방출쓰
Comment on lines
33
to
41
| if (newGroupViewModel.newGroupKeywordValue.value.isNotEmpty()) { | ||
| for (i in 0 until binding.cgNewGroupKeyword.childCount) { | ||
| val childChip = binding.cgNewGroupKeyword.getChildAt(i) as Chip | ||
| if (childChip.text == newGroupViewModel.newGroupKeywordValue.value) { | ||
| childChip.isChecked = true | ||
| } | ||
| } | ||
| } | ||
| } |
| } | ||
|
|
||
| private fun loadSplashScreen() { | ||
| lifecycleScope.launch { | ||
| delay(SPLASH_SCREEN_DELAY_TIME) | ||
| navigateToAuth() | ||
| if (authViewModel.isLocalToken()) { | ||
| if (authViewModel.isLocalGroupId()) navigateToMain() else authViewModel.getUserInfo() |
There was a problem hiding this comment.
저는 여기 authViewModel.getUserInfo() 다음에 navigateToOnboarding()을 넣어주는 방식으로 구현했었는데
collectData에서 서버통신 성공여부 검사하고 넘어가는 게 훨씬 안정적이네요! 좋은 로직 같아용
jihyunniiii
reviewed
Mar 12, 2024
Comment on lines
+35
to
42
| override fun onResume() { | ||
| super.onResume() | ||
|
|
||
| binding.etNewGroupInputGroupName.btnEditTextCheck.isEnabled = | ||
| newGroupViewModel.isNewGroupBtnCheckName.value | ||
| } | ||
|
|
||
| private fun addListeners() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
저빼고 된다니깐 넘어갈게요! 제 실기기 문제인가봐요 ㅠ
To Reviewers 📢