Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] 2.0.0 업데이트 #250

Merged
merged 8 commits into from
Mar 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr_builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Access BASE_URL
env:
HFM_BASE_URL: ${{ secrets.BASE_URL }}
run: echo "base.url=\"$BASE_URL\"" >> local.properties
run: echo "dev.base.url=\"$BASE_URL\"" >> local.properties

- name: Access IO_SENTRY_DSN
env:
Expand Down
8 changes: 4 additions & 4 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,10 @@ android {
applicationId = "org.sopt.pingle"
minSdk = 28
targetSdk = 34
versionCode = 15
versionName = "1.1.0"
versionCode = 16
versionName = "2.0.0"

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
buildConfigField("String", "BASE_URL", properties["base.url"].toString())
buildConfigField("String", "ACCESS_TOKEN", properties["access.token"].toString())
buildConfigField(
"String",
"NAVER_MAP_CLIENT_ID",
Expand All @@ -50,11 +48,13 @@ android {
buildTypes {
debug {
isMinifyEnabled = false
buildConfigField("String", "BASE_URL", properties["dev.base.url"].toString())
buildConfigField("String", "AMPLITUDE_API_KEY", properties["amplitude.dev.api.key"].toString())
}
release {
isMinifyEnabled = true
isShrinkResources = true
buildConfigField("String", "BASE_URL", properties["prod.base.url"].toString())
buildConfigField("String", "AMPLITUDE_API_KEY", properties["amplitude.prod.api.key"].toString())
proguardFiles(
getDefaultProguardFile("proguard-android-optimize.txt"),
Expand Down
16 changes: 6 additions & 10 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,12 @@
android:exported="false"
android:screenOrientation="portrait"
tools:ignore="LockedOrientationActivity" />

<activity
android:name=".presentation.ui.newgroup.NewGroupActivity"
android:exported="false"
android:screenOrientation="portrait"
tools:ignore="LockedOrientationActivity" />
<activity
android:name=".presentation.ui.newgroup.newgroupinfo.NewGroupInfoActivity"
android:exported="false"
android:screenOrientation="portrait"
tools:ignore="LockedOrientationActivity" />
<activity
android:name=".presentation.ui.newgroup.newgroupannouncement.NewGroupAnnouncementActivity"
android:exported="false"
Expand All @@ -102,11 +98,6 @@
android:exported="false"
android:screenOrientation="portrait"
tools:ignore="LockedOrientationActivity" />
<activity
android:name=".presentation.ui.main.planannouncement.PlanAnnouncementActivity"
android:exported="false"
android:screenOrientation="portrait"
tools:ignore="LockedOrientationActivity" />
<activity
android:name=".presentation.ui.onboarding.onboarding.OnboardingActivity"
android:exported="false"
Expand All @@ -128,6 +119,11 @@
android:screenOrientation="portrait"
android:windowSoftInputMode="adjustNothing"
tools:ignore="LockedOrientationActivity" />
<activity
android:name=".presentation.ui.main.planannouncement.PlanAnnouncementActivity"
android:exported="false"
android:screenOrientation="portrait"
tools:ignore="LockedOrientationActivity" />
<activity
android:name=".presentation.ui.search.SearchActivity"
android:exported="false"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,5 @@ class PingleLocalDataSourceImpl @Inject constructor(
const val REFRESH_TOKEN = "RefreshToken"
const val GROUP_ID = "GroupId"
const val GROUP_NAME = "GroupName"
const val MEETING_COUNT = "MeetingCount"
const val PARTICIPANTS_COUNT = "ParticipantsCount"
const val GROUP_KEYWORD = "GroupKeyWord"
const val IS_OWNER = "IsOwner"
const val GROUP_CODE = "GroupCode"
}
}
12 changes: 6 additions & 6 deletions app/src/main/java/org/sopt/pingle/di/DataSourceModule.kt
Original file line number Diff line number Diff line change
Expand Up @@ -53,25 +53,25 @@ abstract class DataSourceModule {

@Binds
@Singleton
abstract fun bindsParticipantRemoteDataSource(participantRemoteDataSourceImpl: ParticipantRemoteDataSourceImpl): ParticipantRemoteDataSource
abstract fun bindsMyGroupListRemoteDataSource(myGroupListRemoteDataSourceImpl: MyGroupListRemoteDataSourceImpl): MyGroupListRemoteDataSource

@Binds
@Singleton
abstract fun bindsPingleRemoteDataSource(pingleRemoteDataSourceImpl: PingleRemoteDataSourceImpl): PingleRemoteDataSource
abstract fun bindsNewGroupRemoteDataSource(newGroupRemoteDataSourceImpl: NewGroupRemoteDataSourceImpl): NewGroupRemoteDataSource

@Binds
@Singleton
abstract fun bindsPlanRemoteDataSource(planRemoteDataSourceImpl: PlanRemoteDataSourceImpl): PlanRemoteDataSource
abstract fun bindsParticipantRemoteDataSource(participantRemoteDataSourceImpl: ParticipantRemoteDataSourceImpl): ParticipantRemoteDataSource

@Binds
@Singleton
abstract fun bindsRankingRemoteDataSource(rankingRemoteDataSourceImpl: RankingRemoteDataSourceImpl): RankingRemoteDataSource
abstract fun bindsPingleRemoteDataSource(pingleRemoteDataSourceImpl: PingleRemoteDataSourceImpl): PingleRemoteDataSource

@Binds
@Singleton
abstract fun bindsMyGroupListRemoteDataSource(myGroupListRemoteDataSourceImpl: MyGroupListRemoteDataSourceImpl): MyGroupListRemoteDataSource
abstract fun bindsPlanRemoteDataSource(planRemoteDataSourceImpl: PlanRemoteDataSourceImpl): PlanRemoteDataSource

@Binds
@Singleton
abstract fun bindsNewGroupRemoteDataSource(newGroupRemoteDataSourceImpl: NewGroupRemoteDataSourceImpl): NewGroupRemoteDataSource
abstract fun bindsRankingRemoteDataSource(rankingRemoteDataSourceImpl: RankingRemoteDataSourceImpl): RankingRemoteDataSource
}
12 changes: 6 additions & 6 deletions app/src/main/java/org/sopt/pingle/di/RepositoryModule.kt
Original file line number Diff line number Diff line change
Expand Up @@ -47,25 +47,25 @@ abstract class RepositoryModule {

@Binds
@Singleton
abstract fun bindsParticipantRepository(participantRepositoryImpl: ParticipantRepositoryImpl): ParticipantRepository
abstract fun bindsMyGroupListRepository(myGroupListRepositoryImpl: MyGroupListRepositoryImpl): MyGroupListRepository

@Binds
@Singleton
abstract fun bindsPingleRepository(pingleRepositoryImpl: PingleRepositoryImpl): PingleRepository
abstract fun bindsNewGroupRepository(newGroupRepositoryImpl: NewGroupRepositoryImpl): NewGroupRepository

@Binds
@Singleton
abstract fun bindsPlanRepository(planRepositoryImpl: PlanRepositoryImpl): PlanRepository
abstract fun bindsParticipantRepository(participantRepositoryImpl: ParticipantRepositoryImpl): ParticipantRepository

@Binds
@Singleton
abstract fun bindsRankingRepository(rankingRepositoryImpl: RankingRepositoryImpl): RankingRepository
abstract fun bindsPingleRepository(pingleRepositoryImpl: PingleRepositoryImpl): PingleRepository

@Binds
@Singleton
abstract fun bindsMyGroupListRepository(myGroupListRepositoryImpl: MyGroupListRepositoryImpl): MyGroupListRepository
abstract fun bindsPlanRepository(planRepositoryImpl: PlanRepositoryImpl): PlanRepository

@Binds
@Singleton
abstract fun bindsNewGroupRepository(newGroupRepositoryImpl: NewGroupRepositoryImpl): NewGroupRepository
abstract fun bindsRankingRepository(rankingRepositoryImpl: RankingRepositoryImpl): RankingRepository
}
20 changes: 10 additions & 10 deletions app/src/main/java/org/sopt/pingle/di/ServiceModule.kt
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,16 @@ object ServiceModule {
fun providesMapService(@Pingle retrofit: Retrofit): MapService =
retrofit.create(MapService::class.java)

@Provides
@Singleton
fun providesMyGroupListService(@Pingle retrofit: Retrofit): MyGroupListService =
retrofit.create(MyGroupListService::class.java)

@Provides
@Singleton
fun providesNewGroupService(@Pingle retrofit: Retrofit): NewGroupService =
retrofit.create(NewGroupService::class.java)

@Provides
@Singleton
fun providesParticipantService(@Pingle retrofit: Retrofit): ParticipantService =
Expand All @@ -61,14 +71,4 @@ object ServiceModule {
@Singleton
fun providesRankingService(@Pingle retrofit: Retrofit): RankingService =
retrofit.create(RankingService::class.java)

@Provides
@Singleton
fun providesMyGroupListService(@Pingle retrofit: Retrofit): MyGroupListService =
retrofit.create(MyGroupListService::class.java)

@Provides
@Singleton
fun providesNewGroupService(@Pingle retrofit: Retrofit): NewGroupService =
retrofit.create(NewGroupService::class.java)
}
40 changes: 20 additions & 20 deletions app/src/main/java/org/sopt/pingle/di/UseCaseModule.kt
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,26 @@ class UseCaseModule {
fun providesGetMapPingleListUseCase(mapRepository: MapRepository): GetMapPingleListUseCase =
GetMapPingleListUseCase(mapRepository = mapRepository)

@Provides
@Singleton
fun providesGetMyGroupListUseCase(myGroupListRepository: MyGroupListRepository): GetMyGroupListUseCase =
GetMyGroupListUseCase(myGroupListRepository = myGroupListRepository)

@Provides
@Singleton
fun providesGetMyPingleListUseCase(pingleRepository: PingleRepository): GetMyPingleListUseCase =
GetMyPingleListUseCase(pingleRepository = pingleRepository)

@Provides
@Singleton
fun providesGetNewGroupCheckNameUseCase(newGroupRepository: NewGroupRepository): GetNewGroupCheckNameUseCase =
GetNewGroupCheckNameUseCase(newGroupRepository = newGroupRepository)

@Provides
@Singleton
fun providesGetNewGroupKeywordsUseCase(newGroupRepository: NewGroupRepository): GetNewGroupKeywordsUserCase =
GetNewGroupKeywordsUserCase(newGroupRepository = newGroupRepository)

@Provides
@Singleton
fun providesGetParticipantListUseCase(participantRepository: ParticipantRepository): GetParticipantListUseCase =
Expand Down Expand Up @@ -103,6 +118,11 @@ class UseCaseModule {
fun providesPostJoinGroupCodeUseCase(joinGroupRepository: JoinGroupRepository): PostJoinGroupCodeUseCase =
PostJoinGroupCodeUseCase(joinGroupRepository = joinGroupRepository)

@Provides
@Singleton
fun providesPostNewGroupCreateUseCase(newGroupRepository: NewGroupRepository): PostNewGroupCreateUseCase =
PostNewGroupCreateUseCase(newGroupRepository = newGroupRepository)

@Provides
@Singleton
fun providesPostPingleJoinUseCase(pingleRepository: PingleRepository): PostPingleJoinUseCase =
Expand All @@ -112,24 +132,4 @@ class UseCaseModule {
@Singleton
fun providesPostPlanMeetingUseCase(planRepository: PlanRepository): PostPlanMeetingUseCase =
PostPlanMeetingUseCase(planRepository = planRepository)

@Provides
@Singleton
fun providesGetMyGroupListUseCase(myGroupListRepository: MyGroupListRepository): GetMyGroupListUseCase =
GetMyGroupListUseCase(myGroupListRepository = myGroupListRepository)

@Provides
@Singleton
fun providesGetNewGroupKeywordsUseCase(newGroupRepository: NewGroupRepository): GetNewGroupKeywordsUserCase =
GetNewGroupKeywordsUserCase(newGroupRepository = newGroupRepository)

@Provides
@Singleton
fun providesGetNewGroupCheckNameUseCase(newGroupRepository: NewGroupRepository): GetNewGroupCheckNameUseCase =
GetNewGroupCheckNameUseCase(newGroupRepository = newGroupRepository)

@Provides
@Singleton
fun providesPostNewGroupCreateUseCase(newGroupRepository: NewGroupRepository): PostNewGroupCreateUseCase =
PostNewGroupCreateUseCase(newGroupRepository = newGroupRepository)
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import org.sopt.pingle.util.AmplitudeUtils
import org.sopt.pingle.util.activity.setDoubleBackPressToExit
import org.sopt.pingle.util.base.BindingActivity
import org.sopt.pingle.util.view.UiState
import org.sopt.pingle.util.view.setOnSingleClickListener
import timber.log.Timber

@AndroidEntryPoint
Expand All @@ -44,7 +45,7 @@ class AuthActivity : BindingActivity<ActivityAuthBinding>(R.layout.activity_auth
}

private fun addListeners() {
binding.btnAuthKakao.setOnClickListener {
binding.btnAuthKakao.setOnSingleClickListener {
kakaoAuthService.loginKakao(viewModel::login, viewModel::saveAccount)
AmplitudeUtils.trackEventWithProperty(START_SIGNUP, SIGNUP_TYPE, KAKAO)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ class AuthViewModel @Inject constructor(
authRepository.postLogin(
kakaoAccessToken,
RequestAuthDto(LOGIN_PLATFORM)
).onSuccess { authEntitiy ->
).onSuccess { authEntity ->
with(localStorage) {
isLogin = true
accessToken = (HEADER_BEARER + authEntitiy.accessToken)
refreshToken = (HEADER_BEARER + authEntitiy.refreshToken)
accessToken = (HEADER_BEARER + authEntity.accessToken)
refreshToken = (HEADER_BEARER + authEntity.refreshToken)
}
_loginState.value = UiState.Success(Unit)
}.onFailure {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import org.sopt.pingle.util.component.PingleSnackbar
import org.sopt.pingle.util.context.hideKeyboard
import org.sopt.pingle.util.context.stringOf
import org.sopt.pingle.util.view.UiState
import org.sopt.pingle.util.view.setOnSingleClickListener
import timber.log.Timber

@AndroidEntryPoint
Expand Down Expand Up @@ -45,10 +46,10 @@ class JoinGroupCodeActivity :
hideKeyboard(binding.etJoinGroupCodeInvitation)
}

binding.btnJoinGroupCodeNext.setOnClickListener {
binding.btnJoinGroupCodeNext.setOnSingleClickListener {
viewModel.joinGroupCodeState(
teamId = teamId,
joinGroupEntity = JoinGroupCodeEntity(viewModel.joinGroupCodeEditText.value.toString())
joinGroupEntity = JoinGroupCodeEntity(viewModel.joinGroupCodeEditText.value)
)

AmplitudeUtils.trackEvent(CLICK_EXISTINGGROUP_ENTER)
Expand Down Expand Up @@ -141,7 +142,7 @@ class JoinGroupCodeActivity :
companion object {
const val TEAM_ID = "teamId"
const val GROUP_NAME = "groupName"
const val LOADING = "Loding"
const val LOADING = "Loading"
const val EMPTY = "Empty"
const val JOIN_GROUP_CODE_ACTIVITY = "JoinGroupCodeActivity"
const val SNACKBAR_BOTTOM_MARGIN = 97
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ class MapFragment : BindingFragment<FragmentMapBinding>(R.layout.fragment_map),
private fun makeMarkers(pinEntityList: List<PinEntity>) {
homeViewModel.clearMarkerModelData()

pinEntityList.mapIndexed { index, pinEntity ->
pinEntityList.mapIndexed { _, pinEntity ->
pinEntity.toMarkerModel().apply {
this.marker.apply {
map = naverMap
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import org.sopt.pingle.util.component.PingleSnackbar
import org.sopt.pingle.util.fragment.navigateToWebView
import org.sopt.pingle.util.fragment.stringOf
import org.sopt.pingle.util.view.UiState
import org.sopt.pingle.util.view.setOnSingleClickListener
import timber.log.Timber

@AndroidEntryPoint
Expand Down Expand Up @@ -55,11 +56,11 @@ class MoreFragment : BindingFragment<FragmentMoreBinding>(R.layout.fragment_more
}

private fun addListeners() {
binding.tvMoreContactTitle.setOnClickListener {
binding.tvMoreContactTitle.setOnSingleClickListener {
startActivity(navigateToWebView(CONTACT))
}

binding.tvMoreNoticeTitle.setOnClickListener {
binding.tvMoreNoticeTitle.setOnSingleClickListener {
startActivity(navigateToWebView(NOTICE))
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ class PlanLocationFragment :
collectData()
}

override fun onDestroyView() {
binding.rvPlanLocationList.adapter = null
super.onDestroyView()
}

private fun initLayout() {
binding.rvPlanLocationList.adapter = planLocationAdapter
}
Expand Down Expand Up @@ -77,9 +82,4 @@ class PlanLocationFragment :
private fun deleteOldPosition(position: Int) {
planLocationViewModel.updatePlanLocationList(position)
}

override fun onDestroyView() {
binding.rvPlanLocationList.adapter = null
super.onDestroyView()
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class PlanOpenChattingFragment :
}

private fun collectData() {
planViewModel.planOpenChattingLink.flowWithLifecycle(viewLifecycleOwner.lifecycle).onEach { openChattingLink ->
planViewModel.planOpenChattingLink.flowWithLifecycle(viewLifecycleOwner.lifecycle).onEach {
planViewModel.validityOpenChattingLink()
}.launchIn(viewLifecycleOwner.lifecycleScope)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,4 @@ abstract class BindingFragment<T : ViewDataBinding>(@LayoutRes private val layou
binding.lifecycleOwner = this.viewLifecycleOwner
return binding.root
}

override fun onDestroyView() {
super.onDestroyView()
}
}
Loading
Loading