Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Wall sprites #1123

Merged
merged 1 commit into from
Sep 5, 2016
Merged

Conversation

Dormanil
Copy link
Contributor

@Dormanil Dormanil commented Sep 4, 2016

I mixed up some sprites and made one that was entirely wrong, but this little fix should make them okay again.

I mixed up some sprites and made one that was entirely wrong, but this little fix should make them okay again.
@Dormanil
Copy link
Contributor Author

Dormanil commented Sep 4, 2016

Before: snippet1
After: snippet2

@TomMalbran
Copy link
Contributor

I see a couple of lines in between the walls like on row 3 column 12, and on row 6 column 12 (each tile is a cell). Is that an issue with the sprite or with rendering?

@bjubes
Copy link
Collaborator

bjubes commented Sep 5, 2016

Im gonna hold of on this one for now due to @TomMalbran comment and #1142

@Dormanil
Copy link
Contributor Author

Dormanil commented Sep 5, 2016

That is a rendering issue, the sprite itself is clean from those lines.

And the fixes to the XML file and to the spritesheet are favourable regardless of #1142. Imagine someone implements the changes discussed in #1142 but doesn't notice the errors I fixed? Then we have nicer looking sprites indeed, but the error in XML and Sprite is still there. It's just safer to fix it now than to hope that the next contributor notices the errors.

@TomMalbran
Copy link
Contributor

If this is a rendering issue, then is fine for now. We should still merge it to fix the XML issue. If needed we can do a new issue/pr for the other stuff.

@mikejbrown mikejbrown merged commit b3cbb9f into TeamPorcupine:master Sep 5, 2016
@mikejbrown
Copy link
Contributor

Going ahead and merging for the fixes. The sprite can be changed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants