DRAW-412 이미 게임중인 유저 중복 참여 방지 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunwoongH
changed the title
SunwoongH
reviewed
Nov 6, 2024
Comment on lines
+40
to
+45
| if (gameInfo.room.isRandomMatching) { | ||
| for (player in gameInfo.room.players) { | ||
| val session = sessionManager.getSession(player.userId) ?: continue | ||
| session.origin.close() | ||
| } | ||
| } |
There was a problem hiding this comment.
P3
sessionManager.unregisterSession(session.id) 로직도 추가하면 좋을 것 같습니다.
There was a problem hiding this comment.
세션 끊김 공통 부분이 실행되어 해당 파트에서 처리됩니다
| afterConnect(sessionDto) | ||
| } catch (ex: XorkerException) { | ||
| webSocketExceptionHandler.handleXorkerException(session, RequestAction.INIT, ex) | ||
| throw ex |
There was a problem hiding this comment.
throw는 세션을 끊김 위해 던지는 것으로
공통 응답처리는 63번째 라인이 하고 있습니다
| @@ -20,6 +20,7 @@ data object AlreadyJoinRoomException : ClientException("c005", "이미 참여한 | |||
| data object InvalidRequestOnlyMyTurnException : ClientException("c006", "요청자의 차례가 아니라서 처리 불가능") { private fun readResolve(): Any = InvalidRequestOnlyMyTurnException } | |||
| data object InvalidRequestOtherPlayingException : ClientException("c007", "진행 중인 게임 방이 있습니다.") { private fun readResolve(): Any = InvalidRequestOtherPlayingException } | |||
| data object AlreadyPlayingRoomException : ClientException("c008", "진행 중인 게임 방에는 참여할 수 없습니다.") { private fun readResolve(): Any = AlreadyPlayingRoomException } | |||
| data object AlreadyPlayingPlayerException : ClientException("c010", "한 유저가 여러번 접속 시도를 하고 있습니다.") { private fun readResolve(): Any = AlreadyPlayingRoomException } | |||
There was a problem hiding this comment.
P1
readResolve() 반환 값에 다른 예외가 지정되어 있습니다.
SunwoongH
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Jira ✔
Description ✔
PR Rule ✔
P1: 꼭 반영해주세요 (Request changes)
P2: 적극적으로 고려해주세요 (Request changes)
P3: 웬만하면 반영해 주세요 (Comment)
P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
P5: 그냥 사소한 의견입니다 (Approve)