Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Quaternions are used incorrectly #121

Open
Nielsbishere opened this issue Jan 16, 2019 · 1 comment
Open

Quaternions are used incorrectly #121

Nielsbishere opened this issue Jan 16, 2019 · 1 comment
Labels
design change Request to re-design a system/class/etc.

Comments

@Nielsbishere
Copy link
Contributor

Is your design request related to a problem? Please describe.
The current implementation of parenting only uses euler angles that get converted to quaternions and then to matrices. This is correct, but doesn't make any sense. It would be better to convert "all" matrices to quaternions; reducing the memory/bandwidth cost and increasing performance.

Describe the solution you'd like
Only use matrices when needed (like clip space conversions) and use quaternions otherwise.

Describe alternatives you've considered
Matrices can still be used, but will result into rotations being less accurate and potential rendering issues.

Additional context
N.A.

@Nielsbishere Nielsbishere added the design change Request to re-design a system/class/etc. label Jan 16, 2019
@VZout
Copy link
Contributor

VZout commented May 6, 2019

Currently we also have a used_quaternion boolean. This is quite a bad way to handle quaternions. Requires a better version in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design change Request to re-design a system/class/etc.
Projects
None yet
Development

No branches or pull requests

2 participants