Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: multiline enum was generating bad swagger #84

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

shane-tw
Copy link
Contributor

@shane-tw shane-tw commented Oct 8, 2021

It was resulting in enum values such as "tasks\n\ttasks.tasklists" if there was a newline between the two.

@shane-tw shane-tw force-pushed the fix/multiline-enum-issues branch from ab91851 to fcb61ef Compare October 8, 2021 11:16
@Teamwork Teamwork deleted a comment from codecov bot Oct 8, 2021
@rafaeljusto
Copy link
Contributor

Maybe you could add a test scenario to the testdata folder covering this issue?

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #84 (abd58af) into master (5465e14) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head abd58af differs from pull request most recent head f2f9e18. Consider uploading reports for the commit f2f9e18 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   73.74%   73.75%   +0.01%     
==========================================
  Files          10       10              
  Lines        1489     1490       +1     
==========================================
+ Hits         1098     1099       +1     
  Misses        283      283              
  Partials      108      108              
Impacted Files Coverage Δ
docparse/jsonschema.go 68.90% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5465e14...f2f9e18. Read the comment docs.

@shane-tw
Copy link
Contributor Author

shane-tw commented Oct 8, 2021

done I think, I just updated the existing test to use a newline

@shane-tw shane-tw merged commit 1cc15ec into master Oct 8, 2021
@shane-tw shane-tw deleted the fix/multiline-enum-issues branch October 8, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants