show value received in error #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesartw
approved these changes
Aug 7, 2024
|
I actually now am nervous to merge this. It's going to break all of our tests where we check the validation error matches that old string :( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
It could be time for a v2, if you have the time and resources... we can probably consolidate a good few funcs as well with generics 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on some tests I noticed that when using
Includeyou don't get the value that was being passed in to the validator so it can be difficult to tell if you just sent it an empty value or just the value was wrong. This adds agot "x"suffix to the string.