Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Phalcon installation and code base update #6443

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Fix Phalcon installation and code base update #6443

merged 6 commits into from
Mar 15, 2021

Conversation

Jeckerson
Copy link
Contributor

Hello!

psr extension is required for phalcon work. I also updated code base...

@joanhey
Copy link
Contributor

joanhey commented Mar 14, 2021

Could you try to update the mongodb variant, if the bug is fixed ?

Good PR !!

@Jeckerson
Copy link
Contributor Author

@joanhey Can't understand how it works in terms of MongoDB...

In the docs rules it has:

The schema for World is id (int, primary key) and randomNumber (int), except for MongoDB, wherein the identity column is _id, with the leading underscore.

So, when I keep response as is it will send warning message:

WARN for http://tfb-server:8080/mongodb/queries?queries=2
An extra key(s) is being included with the db object: _id

Meanwhile, when I disable id key:

WARN for http://tfb-server:8080/mongodb/queries?queries=501
Response object was missing required key: id

FAIL for http://tfb-server:8080/mongodb/queries?queries=foo
Response object was missing required key: id

@NateBrady23 NateBrady23 merged commit a3771b1 into TechEmpower:master Mar 15, 2021
andreasrueb pushed a commit to digitallyinduced/IHP-FrameworkBenchmarks that referenced this pull request Apr 13, 2021
* Fix installation of Phalcon in dockerfiles

* Reformat and update code base

* Enable "plaintext_url" benchmark in Phalcon Micro

* Remove import of functions

* Reformat code

* Fix Phalcon's MongoDB benchmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants