Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better tile intersection #1

Merged
merged 1 commit into from
May 6, 2023
Merged

feat: better tile intersection #1

merged 1 commit into from
May 6, 2023

Conversation

Chicken
Copy link
Contributor

@Chicken Chicken commented May 4, 2023

I do believe the old way of converting to tiles and just selecting tiles fully inside it is wrong- rather select all tiles required to fully select the area user expects to be hidden / shown.
Ignore IDE sorting imports, couldn't be bothered to revert.

Old New
image image

@TechnicJelle TechnicJelle self-requested a review May 6, 2023 16:05
Copy link
Owner

@TechnicJelle TechnicJelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TechnicJelle TechnicJelle merged commit 9603a26 into TechnicJelle:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants