Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate marker movements #1

Merged
merged 3 commits into from
May 20, 2024
Merged

Animate marker movements #1

merged 3 commits into from
May 20, 2024

Conversation

Chicken
Copy link
Contributor

@Chicken Chicken commented May 19, 2024

No description provided.

@TechnicJelle
Copy link
Owner

Thank you for your contribution!

Before I merge it, though, could you fix the fact that it spawns new markers at 0,0,0 and then animates them to their actual position?

Peek.2024-05-19.21-42.mp4

@TechnicJelle
Copy link
Owner

@Chicken said:

if the previous position doesnt exist, then just call the original instead of doing animations
basically how playermarkers do it
https://github.com/BlueMap-Minecraft/BlueMap/blob/a6402850c90e0547d1bdd686ad085a69c6c47137/BlueMapCommon/webapp/src/js/markers/PlayerMarker.js#L110

Thank you for the suggestion! I have implemented it and it seems to work!

@TechnicJelle TechnicJelle merged commit 64a169a into TechnicJelle:main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants