Project-github-tracker #119
Conversation
…n to a new secret.js and put it in the gitignore
code/script.js
Outdated
| <img src="${data.avatar_url}" alt="Avatar of ${data.login}"> | ||
| </a> | ||
| </div> | ||
| <a href="https://github.com/Mimmisen"><h1 class="username">${data.name}<h1></a> |
There was a problem hiding this comment.
data.name gives you your actual name not the username (Mimmisen), you could try to fix that and try out how you get your username (that was also in minimum requirements I think)
There was a problem hiding this comment.
Yes I just wanted to display my name instead with the link to my github but that's true that it says that it should say your username in the requirements I see now so I have changed it
| </div> | ||
| </div> | ||
| `; | ||
| }); |
There was a problem hiding this comment.
here you are missing the names of the main branches (also minimum requirements), so you could add one line more to your innerHTML (if I remember correctly it was repo.default_branch how you get the names of the main branch)
There was a problem hiding this comment.
Great job! Your code is very clean and well structured, which make it easy to read.
Your page fulfills all the minimum requirements (see below) except two: 1) you are printing your real name instead of username, and 2) your are missing the names of the main branches.
Here is a list of the minimum requirements:
- A list of all repos that are forked from Technigo Your username and profile picture
- Most recent update (push) for each repo
- Name of your default branch for each repo
- URL to the actual GitHub repo
- Number of commits for each repo
- It should be responsive (mobile first)
- A visualisation, for example through a pie chart, of how many projects you've done so far, compared to how many you will do (in total it will be 19 weekly projects 🥳) using [Chart.js](https://www.chartjs.org/).
https://github-tracker-bymimmi.netlify.app/