MultiStepForm - Nella and Cholpon #85
Conversation
There was a problem hiding this comment.
Great job with this project!
You've met the requiirements
Also really interesting topic. I love predictions.
Speaking of predictions, it would probably make sense to keep those predictions more as plain data. for example in a json file or at least just in a js file. No need to keep it in a component.
Feedback:
Code Organization: The introduction of new components is well-structured, making the codebase modular and easier to manage.
Styling: The CSS updates ensure a cohesive and visually appealing design. The use of custom fonts and gradients adds a unique touch.
Functionality: Integrating the MultiStepForm component into the main App component is a good approach to manage form states and steps.
Keep up the awesomeness
| selectedMonth={selectedMonth} | ||
| selectedDay={selectedDay} | ||
| /> | ||
| <button type="submit" disabled={!isFormValid}> |
There was a problem hiding this comment.
nice to do a check for disable the button
| }; | ||
|
|
||
| // Function to determine zodiac sign based on day and month | ||
| const getZodiacSign = (day, month) => { |
| if (signGroup) { | ||
| switch (category) { | ||
| case "Career": | ||
| return signGroup.Career; | ||
| case "Love life": | ||
| return signGroup.Love; | ||
| case "Personal life": | ||
| return signGroup.Personal; | ||
| default: | ||
| return "No prediction available."; | ||
| } | ||
| } |
There was a problem hiding this comment.
with a tiny little refactor (love life vs love etc.) you should be able to shorten this to only use this approach:
signGroup[category]
Netlify link
Add your Netlify link here.
PS. Don't forget to add it in your readme as well.
https://2025-horoscope.netlify.app/
Collaborators
https://github.com/cholpoun